Closed
Bug 1264236
Opened 8 years ago
Closed 8 years ago
Implement the support for Directory in DataTransferEvent
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 1 obsolete file)
2.26 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8740868 -
Flags: review?(bugs)
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 1•8 years ago
|
||
Comment on attachment 8740868 [details] [diff] [review] dnd.patch >- bool isDir; >- aRv = file->IsDirectory(&isDir); >+ bool isLink, isSpecial, isFile, isDir; >+ if (NS_WARN_IF(NS_FAILED(file->IsSymlink(&isLink)) || >+ NS_FAILED(file->IsSpecial(&isSpecial))) || >+ isLink || isSpecial) { >+ continue; >+ } This breaks the current handling of links, right? Or explain why drag-and-dropping links keeps working? (it works now in FF and in other browsers) >+ // We are not going to use mFileList, but this object is created when >+ // mFilesAndDirectories array is populated. >+ if (!mFileList) { >+ GetFiles(aRv); >+ if (NS_WARN_IF(aRv.Failed())) { >+ return nullptr; >+ } >+ } So the comment isn't too clear. GetFiles actually ends up populating mFilesAndDirectories. Please explain that in the comment r-, because I don't understand that link handling. Maybe I'm missing something, so if this doesn't break the current behavior, ask review again, but please explain the link handling.
Attachment #8740868 -
Flags: review?(bugs) → review-
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8740868 -
Attachment is obsolete: true
Attachment #8768740 -
Flags: review?(bugs)
Updated•8 years ago
|
Attachment #8768740 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•8 years ago
|
||
I'll add the support for directory in a separate patch. that requires quite big changes in e10s and so on.
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff117266d9de Implement DataTransfer.getFiles, r=smaug
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff117266d9de
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•