1264240 - Allow NPAPI sandbox write access to %LOCALAPPDATA%\Macromedia\Flash Player.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

Adobe have requested that the Windows 64-bit NPAPI sandbox allows write access to %LOCALAPPDATA%\Macromedia\Flash Player.

Comment 1

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7062bba16758cc856b123c0d492564652faedb6f

Comment 2

[Bob Owen (:bobowen)]

Hi KT, hopefully this build from the try push in comment 1 will give the access you require.

https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-7062bba16758cc856b123c0d492564652faedb6f/try-win64/firefox-48.0a1.en-US.win64.installer.exe

I've only given access to the "Flash Player" directory under %LOCALAPPDATA%\Macromedia\ to match the existing access.
It should also give access to create the directory structure as well.

Let me know and I'll get this reviewed and landed.

Comment 3

[KT Kim]

Thanks Bob!!
"comment 1" looks good to me.

Comment 4

[Bob Owen (:bobowen)]

Attachment: Allow NPAPI sandbox write access to %LOCALAPPDATA%\Macromedia\Flash Player

MozReview-Commit-ID: C6PMpIcFMUb

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8741044 [details] [diff] [review]
Allow NPAPI sandbox write access to %LOCALAPPDATA%\Macromedia\Flash Player

Review of attachment 8741044 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginProcessParent.cpp
@@ +111,5 @@
>                            NS_LITERAL_STRING("\\Macromedia"));
> +    AddSandboxAllowedFile(aAllowedDirectories, dirSvc, NS_WIN_LOCAL_APPDATA_DIR,
> +                          NS_LITERAL_STRING("\\Macromedia\\Flash Player"));
> +    AddSandboxAllowedFile(aAllowedDirectories, dirSvc, NS_WIN_LOCAL_APPDATA_DIR,
> +                          NS_LITERAL_STRING("\\Macromedia"));

nit, can we swap these and other dir rules such that "\\ABC" lists before "\\ABC\\Flash Player"?

Comment 6

[Bob Owen (:bobowen)]

(In reply to Jim Mathies [:jimm] from comment #5)

> > +    AddSandboxAllowedFile(aAllowedDirectories, dirSvc, NS_WIN_LOCAL_APPDATA_DIR,
> > +                          NS_LITERAL_STRING("\\Macromedia\\Flash Player"));
> > +    AddSandboxAllowedFile(aAllowedDirectories, dirSvc, NS_WIN_LOCAL_APPDATA_DIR,
> > +                          NS_LITERAL_STRING("\\Macromedia"));
> 
> nit, can we swap these and other dir rules such that "\\ABC" lists before
> "\\ABC\\Flash Player"?

Thanks Jim.
Yes, I think it makes sense to have the file ones first as they'll be used much more.
If I remember correctly it searches through in order for a match.
The directory order doesn't matter much, so I'll do as you suggest to make it more readable.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1942e832fd7a

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1942e832fd7a

Comment 9

[Jim Mathies [:jimm]]

[Tracking Requested - why for this release]:
committed to uplifting this for adobe

Comment 10

[Bob Owen (:bobowen)]

Comment on attachment 8741044 [details] [diff] [review]
Allow NPAPI sandbox write access to %LOCALAPPDATA%\Macromedia\Flash Player

Note to sheriff: patch that landed had some lines moved around to aid readability.

Approval Request Comment
[Feature/regressing bug #]:
New feature requested by Adobe, required for June release.

[User impact if declined]:
Flash Player feature will not operate correctly for 64-bit Firefox.

[Describe test coverage new/current, TreeHerder]:
Automated NPAPI tests in tree.

[Risks and why]:
Low: Very simple addition of new sandbox policy rules.

[String/UUID change made/needed]:
None

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8741044 [details] [diff] [review]
Allow NPAPI sandbox write access to %LOCALAPPDATA%\Macromedia\Flash Player

Partner ask, Aurora47+

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc8dd10e7a95e36e73b1a3c0a9fd6599047ff6a7