Closed
Bug 1264243
Opened 8 years ago
Closed 8 years ago
Prevent "Add to home screen" button from overlaying icon
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(3 files)
If the translation for "Add to home screen" is pretty long then it's possible that the button overlays the page icon (See screenshot). Small screens make this more likely to happen.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
The new implementation will (for very long text) use two lines and in the worst case ellipsize at the end.
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46073/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46073/
Attachment #8740896 -
Flags: review?(ahunt)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment 4•8 years ago
|
||
Comment on attachment 8740896 [details] MozReview Request: Bug 1264243 - Prevent "Add to home screen" button from overlaying page icon. r?ahunt https://reviewboard.mozilla.org/r/46073/#review42995
Attachment #8740896 -
Flags: review?(ahunt) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7b9c723526fff7835105a1155387fd5b0b96d6a1 Bug 1264243 - Prevent "Add to home screen" button from overlaying page icon. r=ahunt
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7b9c723526ff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•