Closed Bug 1264344 Opened 4 years ago Closed 4 years ago

crash when iceRestart option is provided on first create offer

Categories

(Core :: WebRTC: Signaling, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- unaffected
firefox48 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(2 files)

When using appear.in, the iceRestart option is always true.  This causes a crash because the ice restart mechanics start before the first offer is created.
Comment on attachment 8741014 [details]
MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46125/diff/1-2/
Attachment #8741014 - Attachment description: MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. → MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc
Attachment #8741014 - Flags: review?(docfaraday)
Assignee: nobody → mfroman
Comment on attachment 8741014 [details]
MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc

https://reviewboard.mozilla.org/r/46125/#review42615

::: media/mtransport/transportlayerice.cpp:105
(Diff revision 2)
>                                        RefPtr<NrIceMediaStream> stream,
>                                        int component) {
>    // If SetParameters is called and we already have a stream_, this means
>    // we're handling an ICE restart.  We need to hold the old stream until
>    // we know the new stream is working.
> -  if (stream_ && !old_stream_) {
> +  if (stream_ && !old_stream_ && stream_ != stream) {

Add some parens around the != comparison for readability.
Attachment #8741014 - Flags: review?(docfaraday) → review+
Comment on attachment 8741014 [details]
MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46125/diff/2-3/
Rank: 10
Priority: -- → P1
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2377dfe9e73c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 1264462
Blocks: 1263667
You need to log in before you can comment on or make changes to this bug.