Closed
Bug 1264344
Opened 8 years ago
Closed 8 years ago
crash when iceRestart option is provided on first create offer
Categories
(Core :: WebRTC: Signaling, defect, P1)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
Details
Attachments
(2 files)
When using appear.in, the iceRestart option is always true. This causes a crash because the ice restart mechanics start before the first offer is created.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46125/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46125/
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8741014 [details] MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46125/diff/1-2/
Attachment #8741014 -
Attachment description: MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. → MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc
Attachment #8741014 -
Flags: review?(docfaraday)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mfroman
Comment 3•8 years ago
|
||
Comment on attachment 8741014 [details] MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc https://reviewboard.mozilla.org/r/46125/#review42615 ::: media/mtransport/transportlayerice.cpp:105 (Diff revision 2) > RefPtr<NrIceMediaStream> stream, > int component) { > // If SetParameters is called and we already have a stream_, this means > // we're handling an ICE restart. We need to hold the old stream until > // we know the new stream is working. > - if (stream_ && !old_stream_) { > + if (stream_ && !old_stream_ && stream_ != stream) { Add some parens around the != comparison for readability.
Attachment #8741014 -
Flags: review?(docfaraday) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8741014 [details] MozReview Request: Bug 1264344 - Don't restart ICE on first CreateOffer call if iceRestart option is true. r=bwc Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46125/diff/2-3/
Updated•8 years ago
|
Rank: 10
Priority: -- → P1
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2377dfe9e73c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
status-firefox47:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•