Closed
Bug 1264351
Opened 8 years ago
Closed 8 years ago
Remove the e10s ICE TCP hand break from bug 1206981
Categories
(Core :: WebRTC: Networking, defect, P1)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla48
backlog | webrtc/webaudio+ |
People
(Reporter: drno, Assigned: drno)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•8 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 18
Priority: -- → P1
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46171/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46171/
Updated•8 years ago
|
tracking-e10s:
--- → ?
Comment 2•8 years ago
|
||
Nils, should this block e10s rollout.
Assignee | ||
Comment 3•8 years ago
|
||
No it should not, because the ICE TCP pref itself is still off. So the feature is not turn on either with or without e10s.
Flags: needinfo?(drno)
Updated•8 years ago
|
tracking-e10s:
--- → +
Priority: -- → P1
Assignee | ||
Comment 4•8 years ago
|
||
So in general it seems to work. The "only" problem, which is pretty big, is bug 1266667. But bug 1266667 should not block removing this hand break here. It should "only" block turning the ICE TCP pref on in general.
Assignee | ||
Updated•8 years ago
|
Attachment #8741068 -
Flags: review?(rjesup)
Comment 5•8 years ago
|
||
Comment on attachment 8741068 [details] MozReview Request: Bug 1264351: removed hand break which disables ICE TCP on e10s https://reviewboard.mozilla.org/r/46171/#review45241
Attachment #8741068 -
Flags: review?(rjesup) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1f0c65db1ec
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 9•8 years ago
|
||
As the ICE TCP pref still has not been switched on it would not help to uplift this.
Flags: needinfo?(drno)
You need to log in
before you can comment on or make changes to this bug.
Description
•