Remove the e10s ICE TCP hand break from bug 1206981

RESOLVED FIXED in Firefox 48

Status

()

Core
WebRTC: Networking
P1
normal
Rank:
18
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
backlog: --- → webrtc/webaudio+
Rank: 18
Priority: -- → P1
(Assignee)

Comment 1

2 years ago
Created attachment 8741068 [details]
MozReview Request: Bug 1264351: removed hand break which disables ICE TCP on e10s

Review commit: https://reviewboard.mozilla.org/r/46171/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46171/

Updated

2 years ago
tracking-e10s: --- → ?

Comment 2

2 years ago
Nils, should this block e10s rollout.
tracking-e10s: ? → ---
Flags: needinfo?(drno)
Priority: P1 → --
(Assignee)

Comment 3

2 years ago
No it should not, because the ICE TCP pref itself is still off. So the feature is not turn on either with or without e10s.
Flags: needinfo?(drno)

Updated

2 years ago
tracking-e10s: --- → +
Priority: -- → P1
(Assignee)

Comment 4

2 years ago
So in general it seems to work. The "only" problem, which is pretty big, is bug 1266667. But bug 1266667 should not block removing this hand break here. It should "only" block turning the ICE TCP pref on in general.
(Assignee)

Updated

2 years ago
Attachment #8741068 - Flags: review?(rjesup)
(Assignee)

Updated

2 years ago
See Also: → bug 1266667
Comment on attachment 8741068 [details]
MozReview Request: Bug 1264351: removed hand break which disables ICE TCP on e10s

https://reviewboard.mozilla.org/r/46171/#review45241
Attachment #8741068 - Flags: review?(rjesup) → review+

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1f0c65db1ec

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1f0c65db1ec
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Comment 8

2 years ago
same here, should this uplift to 47 for e10s?
Flags: needinfo?(drno)
(Assignee)

Comment 9

2 years ago
As the ICE TCP pref still has not been switched on it would not help to uplift this.
Flags: needinfo?(drno)
You need to log in before you can comment on or make changes to this bug.