126439 - Alt+F4 beeps in some window

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[[e-mail]]

Using Build ID: 2002021803 on Windows 95 and 98

Steps to reproduce problem:
1. Open/focus one of the windows below and use Alt+F4 to close it

Actual results: Beep before close action

Additional information: The following windows are affected:
Navigator; MailNews; Composer; Address Book; Bookmarks; History;
JavaScript Console; DOM Inspector

The following windows are not affected:
Help; Preferences; Search Messages; Alert; Prompt

Comment 1

[John Morrison]

Aaaaaahhh! The bells. They're won't stop ringing. Make them stop.....

Comment 2

[Phil "clef" Sweeney]

Seeing this on Windows XP with nightly builds from 21 and 22nd of Feb.

I've seen this behaviour in the last few months once before as well.

Comment 3

[:deanis74]

Related to the fix for bug 959?  I also get a beep when pressing Alt+O, for
example, or any combination that doesn't have a menu or HTML access key defined.

cc: jag

Comment 4

[:deanis74]

Or this check-in, which is... crap, it's mine.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsMenuBarFrame.cpp&root=/cvsroot&subdir=mozilla/layout/xul/base/src&command=DIFF_FRAMESET&rev1=1.88&rev2=1.89

Can someone back this out or try a build just before and just after Feb 14 at
19:53 and see if it's my fault?  I have a feeling I should be checking mIsActive
in there.

Comment 5

[:deanis74]

99% sure it's me.  A quick trace through nsMenuBarListener just checks if Alt is
down.  My beeping never checks if the menu bar is active.  Also, all the windows
that Neil listed that beep have menu bars, and all the windows that don't beep
don't have menu bars.

Taking

Comment 6

[:deanis74]

*** Bug 126332 has been marked as a duplicate of this bug. ***

Comment 7

[John Morrison]

reverting to rev 1.88 of nsMenuBarFrame.cpp fixes this for me; Alt-F4 does
not beep when closing the active window.

Comment 8

[:deanis74]

I apologize profusely.  This should be a simple two-line fix.

Comment 9

[:deanis74]

Adding this to the 0.9.9-not-sucking bug.

Comment 10

[:deanis74]

Attachment: cvs diff -u /layout/xul/base/src

this fixes it.	jrgm, can you test and r=?  jag or blake, can you sr=?

Comment 11

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 71831 [details] [diff] [review]
cvs diff -u /layout/xul/base/src

r=pink

Comment 12

[Blake Ross]

Comment on attachment 71831 [details] [diff] [review]
cvs diff -u /layout/xul/base/src

sr=blake

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 71831 [details] [diff] [review]
cvs diff -u /layout/xul/base/src

a=asa (on behalf of drivers) for checkin to the 0.9.9 branch and the 1.0 trunk

Comment 14

[Daniel Veditz [:dveditz]]

Checked into the branch. Dean says he'll do the trunk.

Comment 15

[:deanis74]

FYI: the check-in that caused this was to fix bug 53029

Comment 16

[:deanis74]

checked into the trunk

Comment 17

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.03.13.09 comm bits on win2k --tested with the windows
listed in the original comment (except for DOM Inspector which isn't in the
builds i use): no beeping.