Closed Bug 1264420 Opened 8 years ago Closed 8 years ago

Intermittent bug-1259306.js | Timeout (code -9, args "--baseline-eager --no-fpu")

Categories

(Core :: JavaScript Engine: JIT, defect)

48 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: KWierso, Assigned: jonco)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

This test does take a long time to run (39 seconds locally).  It's probably just going over the timeout occasionally.
Attached patch bug1264420-speed-up-test (obsolete) — Splinter Review
Patch to speed up the test by not creating a new global every time round the oomTest loop.  I verified that the test still fails if the patch to trace shape tables is backed out.
Assignee: nobody → jcoppeard
Attachment #8741420 - Flags: review?(terrence)
Comment on attachment 8741420 [details] [diff] [review]
bug1264420-speed-up-test

Review of attachment 8741420 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8741420 - Flags: review?(terrence) → review+
(In reply to Pulsebot from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/889ea0524ad2

for some reasons this turned from a intermittent failure to a permanent failure https://treeherder.mozilla.org/logviewer.html#?job_id=25898974&repo=mozilla-inbound

and so i had to back this out , sorry Jon
Flags: needinfo?(jcoppeard)
Trying again.  This time, limit the number of full runs through the oomTest loop (we frequently recover from an OOM so the thunk under test may be run many times over).

I verified that this still catches the original problem.
Attachment #8741420 - Attachment is obsolete: true
Flags: needinfo?(jcoppeard)
Attachment #8745312 - Flags: review?(terrence)
Attachment #8745312 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/b6dd238180e9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.