Closed Bug 1264434 Opened 5 years ago Closed 4 years ago

Intermittent browser_webconsole_bug_597136_network_requests_from_chrome.js | uncaught exception - TypeError: subject.sourceName.contains is not a function at listener.observe@browser_webconsole_bug_597136_network_requests_from_chrome.js:19:9

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Version:
48 Branch
Type:
defect

Tracking

(firefox48 fixed, firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: KWierso, Assigned: sjakthol)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1264434 - Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js.
58 bytes, text/x-review-board-request
bgrins
: review+
Details
Priority: -- → P3
String.prototype.contains was removed from Firefox 48 completely after
it was renamed to String.prototype.includes. The test includes a
call to .contains() which is triggered whenever random JavaScript
error occurs during the test (hence the intermittency).

Review commit: https://reviewboard.mozilla.org/r/57774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57774/
Attachment #8760054 - Flags: review?(bgrinstead)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b64b3c829a0
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Comment on attachment 8760054 [details]
Bug 1264434 - Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js.

https://reviewboard.mozilla.org/r/57774/#review54624

Thanks, good catch
Attachment #8760054 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/824355c9efe2
Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/824355c9efe2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.