Closed
Bug 1264434
Opened 6 years ago
Closed 6 years ago
Intermittent browser_webconsole_bug_597136_network_requests_from_chrome.js | uncaught exception - TypeError: subject.sourceName.contains is not a function at listener.observe@browser_webconsole_bug_597136_network_requests_from_chrome.js :19:9
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: KWierso, Assigned: sjakthol)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Updated•6 years ago
|
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
![]() |
Assignee | |
Comment 4•6 years ago
|
||
String.prototype.contains was removed from Firefox 48 completely after it was renamed to String.prototype.includes. The test includes a call to .contains() which is triggered whenever random JavaScript error occurs during the test (hence the intermittency). Review commit: https://reviewboard.mozilla.org/r/57774/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57774/
Attachment #8760054 -
Flags: review?(bgrinstead)
![]() |
Assignee | |
Comment 5•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b64b3c829a0
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Comment 6•6 years ago
|
||
Comment on attachment 8760054 [details] Bug 1264434 - Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js. https://reviewboard.mozilla.org/r/57774/#review54624 Thanks, good catch
Attachment #8760054 -
Flags: review?(bgrinstead) → review+
Comment hidden (Intermittent Failures Robot) |
![]() |
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/824355c9efe2 Use String.prototype.includes in browser_webconsole_bug_597136_network_requests_from_chrome.js. r=bgrins
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/824355c9efe2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 10•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/289be0902bd1
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•