Closed
Bug 1264436
Opened 8 years ago
Closed 8 years ago
Checkbox of commonprefs-options is not themeable, whilst all other checkboxes are
Categories
(DevTools :: Framework, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: alfredkayser, Unassigned)
References
Details
Attachments
(1 file)
In toolbox-options.xhtml, there is: 44 <fieldset id="commonprefs-options" class="options-groupbox"> 45 <legend>&options.commonPrefs.label;</legend> 46 <label title="&options.enablePersistentLogs.tooltip;"> 47 <input type="checkbox" data-pref="devtools.webconsole.persistlog" /> 48 &options.enablePersistentLogs.label; 49 </label> 50 </fieldset> By changing line 48 into the following, the css styling can be applied to input[type=checkbox]+span: 48 <span>&options.enablePersistentLogs.label;</span> All other checkboxes are like this, and just adding this <span> will make these consistent, and allows to style the checkboxes in the same way. This is a regression caused by bug 1246514 - Switch toolbox-options.xul to HTML. Before that this checkbox could be styled by full themes.
Comment 1•8 years ago
|
||
Sounds fine to me
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46225/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46225/
Attachment #8741142 -
Flags: review?(ntim.bugs)
Updated•8 years ago
|
Attachment #8741142 -
Flags: review?(ntim.bugs) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8741142 [details] MozReview Request: Bug 1264436 - Make enable persist logs option markup consistent with others;r=ntim https://reviewboard.mozilla.org/r/46225/#review42851 Looks good to me!
Reporter | ||
Comment 4•8 years ago
|
||
Thanks!
Comment 5•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67c7cdfa1e9b
Updated•8 years ago
|
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/54b5c7592f73
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•