1264467 - Investigate crossOrigin related test failures in testing/web-platform/tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Edgar Chen [:edgar]]

Steps to reproduce:
Open http://w3c-test.org/html/semantics/embedded-content/the-img-element/relevant-mutations.html

Actual results:
Test failed in 
* crossorigin state not changed: empty to anonymous, assert_unreached: update the image data was run Reached unreachable code
* crossorigin state not changed: anonymous to foobar, assert_unreached: update the image data was run Reached unreachable code
* crossorigin state not changed: use-credentials to USE-CREDENTIALS, assert_unreached: update the image data was run Reached unreachable code

Expected results:
Ideally, 100% of these tests would pass.

Comment 1

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #0)
> Test failed in 
> * crossorigin state not changed: empty to anonymous, assert_unreached:
> update the image data was run Reached unreachable code
> * crossorigin state not changed: anonymous to foobar, assert_unreached:
> update the image data was run Reached unreachable code
> * crossorigin state not changed: use-credentials to USE-CREDENTIALS,
> assert_unreached: update the image data was run Reached unreachable code

The relevant mutations for an img element includes "The element's crossorigin attribute's state is changed". But in above three cases, the crossorigin's state isn't changed.

See:
https://html.spec.whatwg.org/multipage/embedded-content.html#relevant-mutations
https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-crossorigin
https://html.spec.whatwg.org/multipage/infrastructure.html#cors-settings-attribute

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 4

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=51e2039af9405dd45e2435feabf41db2c0bc247a&group_state=expanded

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8748994 [details] [diff] [review]
Patch, v2

Review of attachment 8748994 [details] [diff] [review]:
-----------------------------------------------------------------

Force a reload only when the cross origin policy is changed, and do reload after attribute has been set in order to use new cross origin policy correctly.

Comment 6

[Josh Matthews [:jdm]]

Comment on attachment 8748994 [details] [diff] [review]
Patch, v2

Review of attachment 8748994 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93bc222914a2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93bc222914a2