Closed
Bug 1264469
Opened 8 years ago
Closed 8 years ago
Would be nice to be able to open 2 firefox sessions with a different profiles from about:profiles
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
9.10 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8741149 -
Flags: review?(bugs)
Comment 1•8 years ago
|
||
Comment on attachment 8741149 [details] [diff] [review] p2.patch >+ >+ const char *args[] = { "-P", profileName.get() }; nit, char* >+ // If a profile name has been set by env and it's not an empty string we >+ // consider it as the next profile. > arg = PR_GetEnv("XRE_PROFILE_NAME"); >- if (arg) { >+ if (arg && arg[0]) { > ar = ARG_FOUND; > } else { > ar = CheckArg("p", false, &arg); > } so this depends on the other patch, where I was asking whether we want to change the meaning of XRE_PROFILE_NAME So this part may need some changes, depending on what happens in the other bug.
Attachment #8741149 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 2•8 years ago
|
||
Hi baku, Will this let you open 2 side by side versions of Firefox with different profiles? The user only has to have one Firefox version installed to do this? If so, that is very cool! What will the UX look like? How does the user choose to open 2 profiles? Is the first step the platform support and the UX will be in another bug? Thanks!
Comment 3•8 years ago
|
||
(In reply to Tanvi Vyas [:tanvi] from comment #2) > What will the UX look like? How does the user choose to open 2 profiles? > Is the first step the platform support and the UX will be in another bug? Ah, I see you add another button to about:profiles "Exec with this profile".
Assignee | ||
Comment 4•8 years ago
|
||
> Ah, I see you add another button to about:profiles "Exec with this profile".
Right. The name 'exec with this profile' seems super confusing to me. Maybe you can help me with a better name?
Comment 7•8 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #4) > > Ah, I see you add another button to about:profiles "Exec with this profile". > > Right. The name 'exec with this profile' seems super confusing to me. Maybe > you can help me with a better name? Some ideas: Open profile Open profile in new browser Open in second browser Open in new browser Launch profile Launch profile in new browser Launch in second browser Launch in new browser
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0eb46e22a782 https://hg.mozilla.org/mozilla-central/rev/750ff8b64b21
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•