Closed Bug 1264492 Opened 4 years ago Closed 4 years ago

Resolve distribution ping version number conflict

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 --- unaffected
firefox47 --- fixed
firefox48 --- unaffected
fennec 47+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

We just landed bug 1260758 for the added distribution IDs, which bumped the version to 4. However, we need to uplift to beta/aurora but the previous Firefox releases are not necessarily (and unlikely to be) on v3.

Georg, how should we resolve this? Should we leave the version ID the same but just do the analysis anyway?

fyi, docs will update in bug 1264491.
Flags: needinfo?(gfritzsche)
We talked about this today and decided to not worry too much about the version ordering we have on Nightly.

Let's:
* get this as v3 to beta
* make v4 the profileDate addition or whatever is current
* fix the docs accordingly
Flags: needinfo?(gfritzsche)
To summarize the situation:

46: +Distribution ID (bug 1260758)

47: +defaultSearch (bug 1249288)
    +profileDate revision (bug 1246816)

And order of version bumps on Nightly:
 defaultSearch 1->2
 profileDate   2->3
 distribution  3->4
---

So, based on uplifts, I think the following reorganization of history makes sense to me:

46, v2: +distribution ID

47, v4: +defaultSearch
        +profileDate revision
---

I'm not sure how v3 on beta (comment 1) would fit into this. Georg, what do you think?

Note: we'll need to wait for the dependencies to settle before we can't start uplifting version numbers.
Depends on: 1246816, 1249288
Flags: needinfo?(gfritzsche)
tracking-fennec: --- → 46+
Liz, just FYI that we'd like to uplift some version numbers changes (to 46 & 47) to make the version numbers more consistent.
Flags: needinfo?(lhenry)
(In reply to Michael Comella (:mcomella) from comment #3)
> Liz, just FYI that we'd like to uplift some version numbers changes (to 46 &
> 47) to make the version numbers more consistent.

Apparently we're merging 46 to release tomorrow so we're going to:
  * Set beta to v2 (with bug 1260758 uplift)
  * Have Georg's input to decide what version 47 should be & uplift
  * Update the docs accordingly

Since we're not uplifting to Beta, I don't think Liz needs the FYI anymore.
tracking-fennec: 46+ → 47+
Flags: needinfo?(lhenry)
We are migrating beta to release a couple of days early, but could still land work on mozilla-release tomorrow (or... I hate to say it but on the weekend) for the RC2 build on Monday.
(In reply to Michael Comella (:mcomella) from comment #2)
> To summarize the situation:
> 
> 46: +Distribution ID (bug 1260758)
> 
> 47: +defaultSearch (bug 1249288)
>     +profileDate revision (bug 1246816)
> 
> And order of version bumps on Nightly:
>  defaultSearch 1->2
>  profileDate   2->3
>  distribution  3->4
> ---
> 
> So, based on uplifts, I think the following reorganization of history makes
> sense to me:
> 
> 46, v2: +distribution ID
> 
> 47, v4: +defaultSearch
>         +profileDate revision
> ---

This sounds fine with me, i've just got a bit lost in the versioning and what is on which channel.

As long as we are clear on what version numbers we have on release/beta and what addition they go with (for validation & analysis purposes), we will sort it out.
Flags: needinfo?(gfritzsche)
Distribution ID was uplifted to Beta (-> v2) and we landed two new measurements
on Aurora (-> v4).

Review commit: https://reviewboard.mozilla.org/r/48259/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48259/
Attachment #8744042 - Flags: review?(mozilla)
The patch in comment 7 should *only* be uplifted to Aurora, and should not land on central.
Comment on attachment 8744042 [details]
MozReview Request: Bug 1264492 - Increment core ping version to 4. r=mkaply

Note: this should *not* land on central first – is should land only on 47.

Approval Request Comment
[Feature/regressing bug #]: Distribution ID uplifted to Beta to increment version to v2, but two more measurements landed on Aurora, meaning it should be v4 (but is v3 due to the uplift).
[User impact if declined]: It'll make our telemetry analysis less consistent server-side, no direct impact on users.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Extremely low. We increment a number that's only put into a JSON object for upload (i.e. a constant).
[String/UUID change made/needed]: None
Attachment #8744042 - Flags: approval-mozilla-aurora?
Comment on attachment 8744042 [details]
MozReview Request: Bug 1264492 - Increment core ping version to 4. r=mkaply

https://reviewboard.mozilla.org/r/48259/#review44975

LGTM
Attachment #8744042 - Flags: review?(mozilla)
Comment on attachment 8744042 [details]
MozReview Request: Bug 1264492 - Increment core ping version to 4. r=mkaply

https://reviewboard.mozilla.org/r/48259/#review45171
Attachment #8744042 - Flags: review+
Comment on attachment 8744042 [details]
MozReview Request: Bug 1264492 - Increment core ping version to 4. r=mkaply

Improves telemetry data quality, Aurora47+
Attachment #8744042 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.