1264508 - Add helpers for converting ArrayBuffer or BufferSource to nsTArray

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P3)

Description

[Lina Butler (ex-Mozilla)]

Bug 1247685 added some helpers for converting ArrayBuffer and BufferSource (OwningArrayBufferViewOrArrayBuffer) to nsTArray.

It would be nice to move these helpers into the WebIDL code generator, so that any union containing a buffer or view could be copied into an nsTArray.

Comment 1

[Lina Butler (ex-Mozilla)]

I just found TypedArrayCreator, which goes the other way—from nsTArray to ArrayBuffer. This bug is about going from ArrayBuffer to nsTArray, though.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1264508 - Use generic helpers for converting ArrayBuffer or BufferSource to/from nsTArray in Push API code. r?#dom-core!

Comment 3

[Peter Van der Beken [:peterv]]

This was mostly done in bug 1690111, but I'll use this bug to remove the obsolete Push-specific helpers.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/669ac95baa5d
Use generic helpers for converting ArrayBuffer or BufferSource to/from nsTArray in Push API code. r=webidl,saschanaz

Comment 5

[pstanciu]

Backed out for causing (part of commit message)

• Backout link
• Push with failures
• Failure Log

Please take a look at these Mochitests failure:

• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b42d02ab3f03
Use generic helpers for converting ArrayBuffer or BufferSource to/from nsTArray in Push API code. r=webidl,saschanaz

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for causing multiple failures, e.g. on browser_aboutdebugging_serviceworker_pushservice_url.js

• backout: https://hg.mozilla.org/integration/autoland/rev/e78065d39935d36ba336168488b051ed778e305f
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=C6BGL99BTFqhO4hW5yFwhw.0&revision=b42d02ab3f037f5169ae88a1a9ba32b3be96e480
• failure log:
  • TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_serviceworker_pushservice_url.js | Test timed out -
  • TEST-UNEXPECTED-FAIL | dom/push/test/test_register_key.html | Test timed out. -

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f10daac4c929
Use generic helpers for converting ArrayBuffer or BufferSource to/from nsTArray in Push API code. r=webidl,saschanaz

Comment 9

[pstanciu]

Backed out for causing (part of commit message)

• Backout link
• Push with failures
• Failure Log Mochitests
• Failure Log Dev Tools
• Failure Log Junit
• Failure Log Junit - android only

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d532fda8cee4
Use generic helpers for converting ArrayBuffer or BufferSource to/from nsTArray in Push API code. r=webidl,saschanaz

Comment 11

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/d532fda8cee4