Closed
Bug 1264555
Opened 8 years ago
Closed 8 years ago
Remove unused parameter passed to inspector-panel::canAddHTMLChild
Categories
(DevTools :: Inspector, defect, P3)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jdescottes, Assigned: pbro)
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
Follow up to Bug 1261781. I missed one thing during the review. https://hg.mozilla.org/integration/fx-team/file/32d2e4645dde/devtools/client/inspector/inspector-panel.js#l1057 : "root" is passed to canAddHTMLChild which doesn't take any argument. This argument should be removed.
Reporter | ||
Comment 1•8 years ago
|
||
pbro: you mentioned you wanted to fix this, feel free to take it!
Flags: needinfo?(pbrosset)
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(pbrosset)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46383/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46383/
Attachment #8741313 -
Flags: review?(jdescottes)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8741313 [details] MozReview Request: Bug 1264555 - Remove unused node parameter in canAddHTMLChild; r=jdescottes https://reviewboard.mozilla.org/r/46383/#review42935 Perfect. Thanks for fixing this and sorry I missed it in the first place!
Attachment #8741313 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Thanks Julian. Pending try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=610ff851476d
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/529cff9c5663
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•