58 bytes, text/x-review-board-request
Follow up to Bug 1261781. I missed one thing during the review. https://hg.mozilla.org/integration/fx-team/file/32d2e4645dde/devtools/client/inspector/inspector-panel.js#l1057 : "root" is passed to canAddHTMLChild which doesn't take any argument. This argument should be removed.
pbro: you mentioned you wanted to fix this, feel free to take it!
Priority: -- → P3
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Created attachment 8741313 [details] MozReview Request: Bug 1264555 - Remove unused node parameter in canAddHTMLChild; r=jdescottes Review commit: https://reviewboard.mozilla.org/r/46383/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46383/
Attachment #8741313 - Flags: review?(jdescottes)
Comment on attachment 8741313 [details] MozReview Request: Bug 1264555 - Remove unused node parameter in canAddHTMLChild; r=jdescottes https://reviewboard.mozilla.org/r/46383/#review42935 Perfect. Thanks for fixing this and sorry I missed it in the first place!
Attachment #8741313 - Flags: review?(jdescottes) → review+
Thanks Julian. Pending try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=610ff851476d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.