Remove unused parameter passed to inspector-panel::canAddHTMLChild

RESOLVED FIXED in Firefox 48

Status

P3
minor
RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: jdescottes, Assigned: pbro)

Tracking

48 Branch
Firefox 48

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

Follow up to Bug 1261781. I missed one thing during the review. 

https://hg.mozilla.org/integration/fx-team/file/32d2e4645dde/devtools/client/inspector/inspector-panel.js#l1057 : "root" is passed to canAddHTMLChild which doesn't take any argument.

This argument should be removed.
pbro: you mentioned you wanted to fix this, feel free to take it!
Flags: needinfo?(pbrosset)
Priority: -- → P3
Whiteboard: [btpp-backlog]
(Assignee)

Updated

3 years ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: needinfo?(pbrosset)
(Assignee)

Comment 2

3 years ago
Created attachment 8741313 [details]
MozReview Request: Bug 1264555 - Remove unused node parameter in canAddHTMLChild; r=jdescottes

Review commit: https://reviewboard.mozilla.org/r/46383/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46383/
Attachment #8741313 - Flags: review?(jdescottes)
Comment on attachment 8741313 [details]
MozReview Request: Bug 1264555 - Remove unused node parameter in canAddHTMLChild; r=jdescottes

https://reviewboard.mozilla.org/r/46383/#review42935

Perfect. Thanks for fixing this and sorry I missed it in the first place!
Attachment #8741313 - Flags: review?(jdescottes) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/529cff9c5663
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.