Closed
Bug 1264592
Opened 8 years ago
Closed 8 years ago
Intermittent test_tap.html | Document element didn't get painted - got true, expected false
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: cbook, Assigned: kats)
References
()
Details
(Keywords: intermittent-failure, Whiteboard: [gfx-noted])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mstange
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
https://treeherder.mozilla.org/logviewer.html#?job_id=25784709&repo=mozilla-inbound 01:44:22 INFO - 243 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_tap.html | Document element didn't get painted - got true, expected false
Whiteboard: [gfx-noted]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Component: Graphics: Layers → Panning and Zooming
OS: Unspecified → Android
Version: unspecified → 48 Branch
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
status-firefox48:
--- → affected
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bugmail.mozilla
Assignee | ||
Comment 3•8 years ago
|
||
I pushed a try patch with some logging to https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ea2c82448af&selectedJob=20159622, there's an instance of this failure that has a log. I haven't had time to analyze the log output yet.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•8 years ago
|
||
I don't think I added enough logging to diagnose this fully. Some more logging: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bfca2b5a17e
Assignee | ||
Comment 6•8 years ago
|
||
So it looks like there's two paints happening in the period where there's supposed to be no paints. At least one of the paints is because of Fennec's thumbnailing code. I don't know if there's a way to disable that, but it probably shouldn't be marking elements as painted either.
Assignee | ||
Comment 7•8 years ago
|
||
Try push which includes logging and also a patch to make the thumbnailing code not screw with the test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=253e1ecde9ea
Assignee | ||
Comment 8•8 years ago
|
||
^ that looks pretty green, so I'm going to chalk this intermittent entirely up to the thumbnailing code. Patch coming up.
Assignee | ||
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50793/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50793/
Attachment #8749178 -
Flags: review?(mstange)
Comment 10•8 years ago
|
||
Could we use aBuilder->IsPaintingToWindow() instead?
Assignee | ||
Comment 11•8 years ago
|
||
That should be fine, I didn't know what the exact semantics of IsPaintingToWindow() and NS_FRAME_PAINTED_THEBES are.
Comment 12•8 years ago
|
||
NS_FRAME_PAINTED_THEBES is used by checkAndClearPaintedState, which is only used for tests (some mochitests + the magic reftest 'reftest-no-paint' class). I'd be surprised if a test was relying on NS_FRAME_PAINTED_THEBES being added for a non-IsPaintingToWindow paint. I'm not 100% sure about the semantics of IsPaintingToWindow though. If you confirm that fennec thumbnails don't set it and you have a green try push, that should be fine though.
Assignee | ||
Comment 13•8 years ago
|
||
Sounds good. I pushed a try push with the new version at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2da3e3a84a9
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8749178 [details] MozReview Request: Bug 1264592 - When doing thumbnails for fennec, don't mark frames as painted because it can interfere with tests. r?mstange Dropping flag for now.
Attachment #8749178 -
Flags: review?(mstange)
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8749178 [details] MozReview Request: Bug 1264592 - When doing thumbnails for fennec, don't mark frames as painted because it can interfere with tests. r?mstange Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50793/diff/1-2/
Attachment #8749178 -
Flags: review?(mstange)
Comment 16•8 years ago
|
||
Comment on attachment 8749178 [details] MozReview Request: Bug 1264592 - When doing thumbnails for fennec, don't mark frames as painted because it can interfere with tests. r?mstange https://reviewboard.mozilla.org/r/50793/#review47801
Attachment #8749178 -
Flags: review?(mstange) → review+
Reporter | ||
Comment 18•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1df2f5386b3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 19•8 years ago
|
||
Looks like the fix worked, I don't see any new occurrences of this in Orangefactor after the fix landed.
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8749178 [details] MozReview Request: Bug 1264592 - When doing thumbnails for fennec, don't mark frames as painted because it can interfere with tests. r?mstange Approval Request Comment [Feature/regressing bug #]: test added in bug 1257641 fails intermittently on fennec [User impact if declined]: none. in theory this is a test-only change, but the code modified might be being used by add-ons via the DOMWindowUtils API. No non-test code in Firefox itself uses it, but I figured I'd request approval for uplift just to be safe. [Describe test coverage new/current, TreeHerder]: there was a test that was failing intermittently before but isn't now [Risks and why]: about as close to zero as it can get :) [String/UUID change made/needed]: none
Attachment #8749178 -
Flags: approval-mozilla-aurora?
Comment 21•8 years ago
|
||
Comment on attachment 8749178 [details] MozReview Request: Bug 1264592 - When doing thumbnails for fennec, don't mark frames as painted because it can interfere with tests. r?mstange Another APZ scroll fix, should only affect test failures, ok to uplift.
Attachment #8749178 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 22•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0d54a039d16a
You need to log in
before you can comment on or make changes to this bug.
Description
•