1264609 - HOST_CXX should be derived from CXX by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Holler (:decoder)]

+++ This bug was initially created as a clone of Bug #1259382 +++


Since bug 1259382 landed, it seems that HOST_CXX is derived from HOST_CC which is derived from CC. This leads to problems with toolchains where you cannot derive CXX from CC by the name (e.g. afl-clang-fast, afl-clang-fast++).

If we set CC and CXX both explicitly, then I think HOST_CXX should be derived from CXX if it is not set, not from CC.

Thanks!

Comment 1

[Jean-Yves Avenard [:jya]]

for the record, appears to be an issue when using distcc , custom flags aren't being passed to compiler

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

Review commit: https://reviewboard.mozilla.org/r/48285/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48285/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

Aha! I knew there was a case that would be broken... one I forgot to add in the unit test in bug 1266343.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48285/diff/1-2/

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

https://reviewboard.mozilla.org/r/48285/#review47047

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4e9581781cd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4e9581781cd