Closed Bug 1264609 Opened 4 years ago Closed 4 years ago

HOST_CXX should be derived from CXX by default

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: decoder, Unassigned)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1259382 +++


Since bug 1259382 landed, it seems that HOST_CXX is derived from HOST_CC which is derived from CC. This leads to problems with toolchains where you cannot derive CXX from CC by the name (e.g. afl-clang-fast, afl-clang-fast++).

If we set CC and CXX both explicitly, then I think HOST_CXX should be derived from CXX if it is not set, not from CC.

Thanks!
for the record, appears to be an issue when using distcc , custom flags aren't being passed to compiler
No longer blocks: 1259382
Depends on: 1266343
Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

Aha! I knew there was a case that would be broken... one I forgot to add in the unit test in bug 1266343.
Attachment #8744118 - Flags: review?(ted)
Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48285/diff/1-2/
Attachment #8744118 - Attachment description: MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when not cross-compiling. r?ted → MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted
Attachment #8744118 - Flags: review?(ted)
Comment on attachment 8744118 [details]
MozReview Request: Bug 1264609 - Derive HOST_CXX from CXX when it makes sense. r?ted

https://reviewboard.mozilla.org/r/48285/#review47047
Attachment #8744118 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/c4e9581781cd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.