1264651 - remove max_child_script_run_time pref

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Perhaps we should keep this pref and use it if it's lower than the main process one. That still gives us the ability to give e10s a lower script timeout (which would be nice).

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Bill McCloskey (:billm) from comment #1)
> Perhaps we should keep this pref and use it if it's lower than the main
> process one. That still gives us the ability to give e10s a lower script
> timeout (which would be nice).

Under the assumption that we're moving to a word where there is no non-e10s content, why would we want to do that?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: remove_max_child_script_run_time.patch

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: clean_up_max_child_script_run_time_prefs.patch

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

Review of attachment 8741383 [details] [diff] [review]:
-----------------------------------------------------------------

I think it will take at least a year after we ship e10s to get rid of non-e10s. But I guess we can put this code back if we want to decrease the slow script timeout.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ede87db038f
https://hg.mozilla.org/integration/mozilla-inbound/rev/e48a3e3ff578

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ede87db038f
https://hg.mozilla.org/mozilla-central/rev/e48a3e3ff578

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

Approval Request Comment
[Feature/regressing bug #]:
normalizing measurement data between e10s and non-e10s for the slow script notification.
[User impact if declined]:
none.
[Describe test coverage new/current, TreeHerder]:
on mc for a few days.
[Risks and why]: 
low, standardizing on the same timeout value.
[String/UUID change made/needed]:
none

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

slow script measurement in e10s vs non-e10s, Aurora47+

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a83292630dde
https://hg.mozilla.org/releases/mozilla-aurora/rev/afa1902ad1a8