Closed Bug 1264651 Opened 4 years ago Closed 4 years ago

remove max_child_script_run_time pref

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: blassey, Assigned: blassey)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Assignee: jdemooij → blassey.bugs
Perhaps we should keep this pref and use it if it's lower than the main process one. That still gives us the ability to give e10s a lower script timeout (which would be nice).
(In reply to Bill McCloskey (:billm) from comment #1)
> Perhaps we should keep this pref and use it if it's lower than the main
> process one. That still gives us the ability to give e10s a lower script
> timeout (which would be nice).

Under the assumption that we're moving to a word where there is no non-e10s content, why would we want to do that?
Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

Review of attachment 8741383 [details] [diff] [review]:
-----------------------------------------------------------------

I think it will take at least a year after we ship e10s to get rid of non-e10s. But I guess we can put this code back if we want to decrease the slow script timeout.
Attachment #8741383 - Flags: review?(wmccloskey) → review+
Attachment #8741384 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/3ede87db038f
https://hg.mozilla.org/mozilla-central/rev/e48a3e3ff578
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

Approval Request Comment
[Feature/regressing bug #]:
normalizing measurement data between e10s and non-e10s for the slow script notification.
[User impact if declined]:
none.
[Describe test coverage new/current, TreeHerder]:
on mc for a few days.
[Risks and why]: 
low, standardizing on the same timeout value.
[String/UUID change made/needed]:
none
Attachment #8741383 - Flags: approval-mozilla-aurora?
Attachment #8741384 - Flags: approval-mozilla-aurora?
Comment on attachment 8741383 [details] [diff] [review]
remove_max_child_script_run_time.patch

slow script measurement in e10s vs non-e10s, Aurora47+
Attachment #8741383 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8741384 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.