1264659 - Prevent pushing bookmarks to Firefox repos

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

It is currently possible to push bookmarks to all repos on hg.mozilla.org, including Firefox repos.

While nobody has pushed a bookmark yet, the new repos being established in bug 1108729 will add bookmarks to track e.g. central, inbound, aurora, since we're about to increase the chances that someone pushes a bookmark by mistake. Let's nip the chances in the bud.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hghooks: add a hook that disallows pushing bookmarks (bug 1264659); r?smacleod

The intent is to enable this on the Firefox repos to prevent accidents
related to the imminent introduction of bookmarks on the unified Firefox
repos being created in bug 1108729.

Review commit: https://reviewboard.mozilla.org/r/46455/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46455/

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8741392 [details]
MozReview Request: hghooks: add a hook that disallows pushing bookmarks (bug 1264659); r?smacleod

https://reviewboard.mozilla.org/r/46455/#review43019

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/85ea6aff18f45ea3d7b8281d1bc74e43455d9beb
hghooks: add a hook that disallows pushing bookmarks (bug 1264659); r=smacleod

Comment 4

[Gregory Szorc [:gps]]

Deployed. Added the hook to the following repos:

mozilla-central
integration/b2g-inbound
integration/fx-team
integration/mozilla-inbound
releases/mozilla-aurora
releases/mozilla-beta
releases/mozilla-esr38
releases/mozilla-esr45
releases/mozilla-release