1264682 - [rep tests] Add tests for event rep

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Lin Clark [:linclark]]

See Bug 1257552

Comment 1

[Lin Clark [:linclark]]

It looks like only a few events have detailed information displayed: MouseEvent, KeyboardEvent, and MessageEvent. What was the reason for choosing those three?

Comment 2

[Lin Clark [:linclark]]

Attachment: Bug1264682.patch

I think we might want to handle events as an Object... that's what Chrome seems to do and it would come closer to the console's current output.

Comment 3

[Lin Clark [:linclark]]

Attachment: Bug1264682.patch

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8765000 [details] [diff] [review]
Bug1264682.patch

Review of attachment 8765000 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should also cover the MessageEvent.

You can use window.postMessage("test data", "*") + window.addEventListener("message", msgEvent => {}, false);

Honza

::: devtools/client/shared/components/test/mochitest/test_reps_event.html
@@ +24,5 @@
> +    is(renderedRep.type, Event.rep, `Rep correctly selects ${Event.rep.displayName}`);
> +
> +    yield testEvent();
> +    yield testMouseEvent();
> +    yield testKeyboardEvent();

Can you please yet add: testMessageEvent();

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Lin Clark [:linclark] from comment #1)
> It looks like only a few events have detailed information displayed:
> MouseEvent, KeyboardEvent, and MessageEvent. What was the reason for
> choosing those three?
I don't recall, perhaps they have been requested by users. But, not sure what would be the other event types we'd like to support. In any case we should support all of them.

(In reply to Lin Clark [:linclark] from comment #2)
> I think we might want to handle events as an Object... that's what Chrome
> seems to do and it would come closer to the console's current output.

Nice thing about this specific support is that the user doesn't have to inspect the event object (click open/expand etc.) to see the most important values: i.e. coordinates for mouse event, key code for key event, data for the MessageEvent. They are visible immediately without any explicit user action.

In any case Event object should be clickable so, the user can inspect all props in VariablesView.

I vote for supporting this, but if "keeping the same UX" has higher priority now, we might want to use special mode for rendering back-compatible markup (I can't remember what was the suggested name for this mode?)

Honza

Comment 6

[Lin Clark [:linclark]]

Attachment: test-event.patch

Honza's on PTO, so can you review, Mike?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/b425256008f5
[rep tests] Add tests for event rep. r=mikeratcliffe

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b425256008f5