Closed
Bug 1264706
Opened 8 years ago
Closed 8 years ago
Move nsILocalCertService to a more central location
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sicking, Unassigned)
Details
Attachments
(1 file)
8.65 KB,
patch
|
keeler
:
review+
jryans
:
feedback+
|
Details | Diff | Splinter Review |
We're planning on using this code for FlyWeb as well, so it'd be better if it lived someplace where it could be used anywhere within gecko
Attachment #8741424 -
Flags: review?(dkeeler)
Attachment #8741424 -
Flags: feedback?(jryans)
Comment on attachment 8741424 [details] [diff] [review] Patch to fix Review of attachment 8741424 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for moving it! ::: devtools/shared/security/moz.build @@ +9,1 @@ > FINAL_LIBRARY = 'xul' This bit should be removable as well, shouldn't be needed with only JS left.
Attachment #8741424 -
Flags: feedback?(jryans) → feedback+
Comment on attachment 8741424 [details] [diff] [review] Patch to fix Review of attachment 8741424 [details] [diff] [review]: ----------------------------------------------------------------- r=me - just the one comment about where the test ends up. ::: netwerk/test/unit/test_local_cert.js @@ -1,1 @@ > /* Any copyright is dedicated to the Public Domain. I feel like if the implementation is in security/manager/ssl the test should be in security/manager/ssl/tests/unit/
Attachment #8741424 -
Flags: review?(dkeeler) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b0ab5d9e59a https://hg.mozilla.org/mozilla-central/rev/f50dc267404d https://hg.mozilla.org/mozilla-central/rev/89e7caeaad61
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•