Closed Bug 1264706 Opened 4 years ago Closed 4 years ago

Move nsILocalCertService to a more central location

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: sicking, Unassigned)

Details

Attachments

(1 file)

Attached patch Patch to fixSplinter Review
We're planning on using this code for FlyWeb as well, so it'd be better if it lived someplace where it could be used anywhere within gecko
Attachment #8741424 - Flags: review?(dkeeler)
Attachment #8741424 - Flags: feedback?(jryans)
Comment on attachment 8741424 [details] [diff] [review]
Patch to fix

Review of attachment 8741424 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for moving it!

::: devtools/shared/security/moz.build
@@ +9,1 @@
>  FINAL_LIBRARY = 'xul'

This bit should be removable as well, shouldn't be needed with only JS left.
Attachment #8741424 - Flags: feedback?(jryans) → feedback+
Comment on attachment 8741424 [details] [diff] [review]
Patch to fix

Review of attachment 8741424 [details] [diff] [review]:
-----------------------------------------------------------------

r=me - just the one comment about where the test ends up.

::: netwerk/test/unit/test_local_cert.js
@@ -1,1 @@
>  /* Any copyright is dedicated to the Public Domain.

I feel like if the implementation is in security/manager/ssl the test should be in security/manager/ssl/tests/unit/
Attachment #8741424 - Flags: review?(dkeeler) → review+
You need to log in before you can comment on or make changes to this bug.