Closed
Bug 1264710
Opened 8 years ago
Closed 8 years ago
Catch IDB exceptions in IndexedDBHelper
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
IndexedDB methods can throw in case of database corruption (for example, using the same profile with multiple channels; bug 1236557), or if storage is invalided via `nsIQuotaManagerService.reset()` (bug 1185716, comment 13). If this happens, neither the success nor failure callback will be called, deadlocking the caller. This patch just catches those exceptions and forwards them to the failure callback. What do you think, Fabrice?
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46471/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46471/
Attachment #8741429 -
Flags: review?(fabrice)
Updated•8 years ago
|
Whiteboard: btpp-active
Updated•8 years ago
|
Attachment #8741429 -
Flags: review?(fabrice) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8741429 [details] MozReview Request: Bug 1264710 - Catch IDB exceptions in `IndexedDBHelper`. r=fabrice https://reviewboard.mozilla.org/r/46471/#review43555
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8741429 [details] MozReview Request: Bug 1264710 - Catch IDB exceptions in `IndexedDBHelper`. r=fabrice Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46471/diff/1-2/
Attachment #8741429 -
Attachment description: MozReview Request: Bug 1264710 - Catch IDB exceptions in `IndexedDBHelper`. r?fabrice → MozReview Request: Bug 1264710 - Catch IDB exceptions in `IndexedDBHelper`. r=fabrice
Assignee | ||
Comment 4•8 years ago
|
||
Fixed up the "forget about site" test to wait on push before testing cache clearing. https://treeherder.mozilla.org/#/jobs?repo=try&revision=15f3b358c09e
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/65a3c56652e5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•