Closed
Bug 1264804
Opened 8 years ago
Closed 8 years ago
Close tabs and toolboxes between tasks in browser_webconsole_netlogging.js
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
For more context: https://bugzilla.mozilla.org/show_bug.cgi?id=1242234#c16 https://bugzilla.mozilla.org/show_bug.cgi?id=1242234#c23
Assignee | ||
Comment 1•8 years ago
|
||
Also adds a new closeTabAndToolbox helper function to shared-head.js Review commit: https://reviewboard.mozilla.org/r/46563/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46563/
Attachment #8741549 -
Flags: review?(pbrosset)
Assignee | ||
Comment 2•8 years ago
|
||
Patrick, I flagged you because of the new shared-head.js function. I think it's pretty useful and was surprised that we didn't have it already but let me know what you think.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=59fe70a90079
Comment 4•8 years ago
|
||
Comment on attachment 8741549 [details] MozReview Request: Bug 1264804 - Clean up tabs between tests in browser_webconsole_netlogging.js;r=pbro https://reviewboard.mozilla.org/r/46563/#review43319 ::: devtools/client/framework/test/shared-head.js:279 (Diff revision 1) > + let target = TargetFactory.forTab(gBrowser.selectedTab); > + if (target) { > + yield gDevTools.closeToolbox(target); > + } > + > + gBrowser.removeCurrentTab(); Maybe call `removeTab` here instead, since we have this function available in the module. It seems to wait for some event, not sure if this is necessary. ::: devtools/client/framework/test/shared-head.js:286 (Diff revision 1) > + > +/** > * Close a toolbox and the current tab. > * @param {Toolbox} toolbox The toolbox to close. > * @return {Promise} Resolves when the toolbox and tab have been destroyed and > - * closed. > + * closed. nit: you made a change here to vertically align "closed" below "Resolves", but you didn't do this in the jsdoc of the new `closeTabAndToolbox` function. Let's be consistent with the rest of the file.
Attachment #8741549 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8741549 [details] MozReview Request: Bug 1264804 - Clean up tabs between tests in browser_webconsole_netlogging.js;r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46563/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
Started using removeTab in both closeToolboxAndTab and closeTabAndToolbox
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=00b04f7a7444
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8741549 [details] MozReview Request: Bug 1264804 - Clean up tabs between tests in browser_webconsole_netlogging.js;r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46563/diff/2-3/
Comment 10•8 years ago
|
||
has conflicts summary: Bug 1264804 - Clean up tabs between tests in browser_webconsole_netlogging.js;r=pbro apply changeset? [ynmpcq?]: y applying 23f9a79ec673 patching file devtools/client/framework/test/shared-head.js Hunk #1 FAILED at 259 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/framework/test/shared-head.js.rej patch failed to apply abort: fix up the working directory and run hg transplant --continue could you take a look, thanks !
Flags: needinfo?(bgrinstead)
Keywords: checkin-needed
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8741549 [details] MozReview Request: Bug 1264804 - Clean up tabs between tests in browser_webconsole_netlogging.js;r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46563/diff/3-4/
Assignee | ||
Comment 12•8 years ago
|
||
Should be rebased now, thanks
Flags: needinfo?(bgrinstead)
Keywords: checkin-needed
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6582d0af6d89
Keywords: checkin-needed
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6582d0af6d89
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•