1264807 - Land user-facing strings for Decoder Doctor work - Need Vista-specific string

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(Spotted by cpearce)
Bug 1262556 landed (and uplifted to Aurora 47) the following strings for Windows:
> decoder.noCodecs.message =
>   To play video, you may need to install Microsoft’s Media Feature Pack.
> decoder.noHWAcceleration.message =
>   To improve video quality, you may need to install Microsoft’s Media Feature Pack.

These are correct, so no need to modify them.

However on Windows Vista, the needed software package is actually called "Platform Update Supplement for Windows Vista".
See https://support.microsoft.com/en-us/kb/2117917

The user notification will point at a SUMO webpage that should contain the correct information, but it would still be good to present the correct name from the get-go, so as not to confuse users.
So we should add the Vista-specific versions of the above strings; And ideally uplift them as well, to make them available in 47.

Assigning to Jared, as he worked on bug 1262556.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

We discussed this elsewhere (I don't see it in the two bugs that I looked in), but we decided this wasn't super necessary because once a user clicks on the notification bar the bar disappears. Users aren't likely to recall the name, and we can rely on SUMO to point users at the correct software for the user's platform.

At this point, it's not worth breaking string freeze. We could add the string and let it ride the 48 train, but I don't see a huge win by uplifting it to 47 and breaking string freeze a second time.

Comment 2

[Chris Peterson [:cpeterson]]

Yes. Having Vista-specific string (replacing "Media Feature Pack" with "Platform Update Supplement") would be nice, but it is not critical. The SUMO page we open has instructions for different Windows versions.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: MozReview Request: Bug 1264807 - Land user-facing Vista-specific string for Decoder Doctor. r?gijs

Review commit: https://reviewboard.mozilla.org/r/48277/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48277/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8744097 [details]
MozReview Request: Bug 1264807 - Land user-facing Vista-specific string for Decoder Doctor. r?gijs

https://reviewboard.mozilla.org/r/48277/#review45129

r=me with "install" rather than "enable"

::: browser/locales/en-US/chrome/browser/browser.properties:766
(Diff revision 1)
>  tabgroups.migration.tabGroupBookmarkFolderName = Bookmarked Tab Groups
>  
>  decoder.noCodecs.button = Learn how
>  decoder.noCodecs.accesskey = L
>  decoder.noCodecs.message = To play video, you may need to install Microsoft’s Media Feature Pack.
> +decoder.noCodecsVista.message = To play video, you may need to enable Microsoft’s Platform Update Supplement for Windows Vista.

Shouldn't this be "install" rather than enable? That's also what the other messages say...

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in

Thanks for catching that.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/81e5bf11a1e6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81e5bf11a1e6