59 bytes, text/x-review-board-request
In the call to StartMacSandbox(MacSandboxInfo aInfo) we pass an instance of a MacSandBoxInfo struct. The struct has a constructor which duplicates several std::string objects. Instead, we could pass aInfo as a const reference and avoid all the string copies. Additionally, if we need to copy the strings, using the default compiler generated version might be equivalent. We can enabled using the new =default syntax. GMP also uses some of the same sandbox setup code and might need some cleanup too.
Assignee: nobody → haftandilian
Comment on attachment 8891468 [details] Bug 1264811 - Use a const reference and a default constructor to simplify the macOS sandbox code; https://reviewboard.mozilla.org/r/162610/#review167940 Thanks for fixing this.
Attachment #8891468 - Flags: review?(haftandilian) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cc29c0db027b Use a const reference and a default constructor to simplify the macOS sandbox code; r=haik
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.