Closed Bug 1264816 Opened 8 years ago Closed 8 years ago

Drop background_color from Web manifest image object

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug)

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

The background_color for image objects never got accepted into the spec, so it should be removed from our implementation.
Blocks: webmanifest
Assignee: nobody → mcaceres
Attachment #8741565 - Flags: review?(mconley)
Comment on attachment 8741565 [details] [diff] [review]
Drops image object's background color member

Review of attachment 8741565 [details] [diff] [review]:
-----------------------------------------------------------------

I assume this was only dropped for the image object, and not for the Web Manifest in general?
Attachment #8741565 - Flags: review?(mconley) → review+
Keywords: checkin-needed
> I assume this was only dropped for the image object, and not for the Web Manifest in general?

Correct. The other remains.
Keywords: checkin-needed
Whiteboard: btpp-active
Attached patch RebasedSplinter Review
Attachment #8741565 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/177d9f1a0f9a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.