1264817 - Stop guarding nspr and icu traversal in disable compile environment builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

We should be able to get them out of this condition now: https://dxr.mozilla.org/mozilla-central/rev/21bf1af375c1fa8565ae3bb2e89bd1a0809363d4/moz.build#64

Which will also allow removing the workaround for artifact builds landed in bug 1262231 (where we're extracting the copy of the data file in the package rather than just using the one in the tree).

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1264817 - Traverse nspr and icu during disable compile environment builds now that we aren't using their build systems. r=glandium

This also allows us to use the in-tree icu data file for artifact builds.

Review commit: https://reviewboard.mozilla.org/r/46605/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46605/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8741586 [details]
MozReview Request: Bug 1264817 - Traverse nspr and icu during disable compile environment builds now that we aren't using their build systems. r=glandium

https://reviewboard.mozilla.org/r/46605/#review43237

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7be61561579d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7be61561579d