Closed
Bug 1264831
Opened 8 years ago
Closed 8 years ago
Misc pyconfigure changes and cleanups
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
as well as os.path.normcase. Review commit: https://reviewboard.mozilla.org/r/46609/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46609/
Attachment #8741592 -
Flags: review?(gps)
Attachment #8741593 -
Flags: review?(gps)
Attachment #8741594 -
Flags: review?(gps)
Attachment #8741595 -
Flags: review?(gps)
Attachment #8741596 -
Flags: review?(gps)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46611/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46611/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46613/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46613/
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46615/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46615/
Assignee | ||
Comment 5•8 years ago
|
||
This removes the last use of complete configure sandbox unlocking. Review commit: https://reviewboard.mozilla.org/r/46617/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46617/
Comment 6•8 years ago
|
||
Comment on attachment 8741592 [details] MozReview Request: Bug 1264831 - Add a few presumably harmless builtins to the sandbox. r?gps https://reviewboard.mozilla.org/r/46609/#review43251
Attachment #8741592 -
Flags: review?(gps) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8741594 [details] MozReview Request: Bug 1264831 - Work around issues with the exec statement in older python 2.7 versions. r?gps https://reviewboard.mozilla.org/r/46613/#review43255 I really wish we could force people to use Python 2.7.9+ so we're guaranteed decent security/crypto defaults and no bugs like this. But too many distros still ship ancient Python 2.7 :/
Attachment #8741594 -
Flags: review?(gps) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8741595 [details] MozReview Request: Bug 1264831 - Defer applying @imports until the function is actually called. r?gps https://reviewboard.mozilla.org/r/46615/#review43259
Attachment #8741595 -
Flags: review?(gps) → review+
Comment 9•8 years ago
|
||
Comment on attachment 8741596 [details] MozReview Request: Bug 1264831 - Use @imports in find_program. r?gps https://reviewboard.mozilla.org/r/46617/#review43261
Attachment #8741596 -
Flags: review?(gps) → review+
Updated•8 years ago
|
Attachment #8741593 -
Flags: review?(gps) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8741593 [details] MozReview Request: Bug 1264831 - Try to detect decorators declared in the sandbox and add some automatic @wraps. r?gps https://reviewboard.mozilla.org/r/46611/#review43263
Assignee | ||
Comment 11•8 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #7) > Comment on attachment 8741594 [details] > MozReview Request: Bug 1264831 - Work around issues with the exec statement > in older python 2.7 versions. r?gps > > https://reviewboard.mozilla.org/r/46613/#review43255 > > I really wish we could force people to use Python 2.7.9+ so we're guaranteed > decent security/crypto defaults and no bugs like this. But too many distros > still ship ancient Python 2.7 :/ More than "too many distros", whatever we use on automation is what has the problem. The use of the exec statement with "in" was solely driven by the builds failing on automation otherwise. People may have filed bugs because it would have been broken on their system, but we've hit the problem on our own well before that. And they still haven't been upgraded.
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/69744c3a2c23 https://hg.mozilla.org/integration/mozilla-inbound/rev/cc9627a61ab1 https://hg.mozilla.org/integration/mozilla-inbound/rev/6b915bf8df2a https://hg.mozilla.org/integration/mozilla-inbound/rev/dc27fd8f2c4e https://hg.mozilla.org/integration/mozilla-inbound/rev/f84123a66e19
Comment 13•8 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #7) > Comment on attachment 8741594 [details] > MozReview Request: Bug 1264831 - Work around issues with the exec statement > in older python 2.7 versions. r?gps > > https://reviewboard.mozilla.org/r/46613/#review43255 > > I really wish we could force people to use Python 2.7.9+ so we're guaranteed > decent security/crypto defaults and no bugs like this. But too many distros > still ship ancient Python 2.7 :/ Perhaps on a Windows build using mozilla-build, a fatal error could be produced if not running the latest mozilla-build version. That would at least aid in figuring out how to avoid such issues for people using the supported build tools.
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69744c3a2c23 https://hg.mozilla.org/mozilla-central/rev/cc9627a61ab1 https://hg.mozilla.org/mozilla-central/rev/6b915bf8df2a https://hg.mozilla.org/mozilla-central/rev/dc27fd8f2c4e https://hg.mozilla.org/mozilla-central/rev/f84123a66e19
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•