Closed
Bug 1264868
Opened 8 years ago
Closed 8 years ago
(Content notifications) Multiple URLS not opening
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 verified)
VERIFIED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | verified |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file)
This morning I got a content notification with multiple links. Clicking the notification opened the app but no new tabs opened.
Assignee | ||
Comment 1•8 years ago
|
||
The current approach only works if the app is still in the background. Killing the process and then clicking on the notification won't open the tabs.
Assignee | ||
Comment 2•8 years ago
|
||
Currently we only handle the VIEW_MULTIPLE intent in onNewIntent(). But this method is not called on the very first start. We need to handle this Intent from onCreate() too.
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47129/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47129/
Attachment #8742326 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8742326 [details] MozReview Request: Bug 1264868 - Handle ACTION_VIEW_MULTIPLE intent when creating BrowserApp. r?mcomella Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47129/diff/1-2/
Comment on attachment 8742326 [details] MozReview Request: Bug 1264868 - Handle ACTION_VIEW_MULTIPLE intent when creating BrowserApp. r?mcomella https://reviewboard.mozilla.org/r/47129/#review44339 Looks good. fwiw, I've had the idea in my head that we should eventually try to move towards `onNewIntent(Intent i) { setIntent(i); }` and doing all of the Intent handling in `onStart` (or whatever the relevant callback is) to avoid duplication like this. ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:818 (Diff revision 2) > } > }) > .run(); > } > > + if (ACTION_VIEW_MULTIPLE.equals(intent.getAction()) && savedInstanceState == null) { I'm not sure if this needs to be down here for other reasons but there is some action handling code higher up that you can move this towards: https://dxr.mozilla.org/mozilla-central/rev/67ac40fb8f680ea5e03805552187ba1b5e8392a1/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#647 ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:1040 (Diff revision 2) > } > }); > } > } > > + private void openMultipleTabsFromIntent(Intent intent) { nit: `final` here and below
Attachment #8742326 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dff5be5628175185fa736bed9bf789fb2ff42504 Bug 1264868 - Handle ACTION_VIEW_MULTIPLE intent when creating BrowserApp. r=mcomella
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dff5be562817
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 8•8 years ago
|
||
Verified as fixed in build 48.0b1; Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•