1264882 - During the tracking protection initial clickthrough there is a slight graphical glitch

Status: VERIFIED FIXED

(Firefox :: Tours, defect, P1)

Description

[Julien Wajsberg [:julienw]]

Attachment: capture

This was the first time I saw the clickthrough about Tracking Protection in Aurora (I didn't update this computer for quite a long time). Current Build ID is 20160414004009, Aurora 47, French locale, Linux.

The click through starts once when we click on "next" on the small popup that explains the first step of the clickthrough. On the latest step, I see this glitch, as shown in the capture.

I have no idea how to start the clickthrough again so I can't give a better STR.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Gijs, do you know who could help on this issue? Thanks

Comment 2

[:Gijs (he/him)]

Panos, can you route this to people who know about tracking protection / control center?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

I can reproduce on Ubuntu. It seems to be a small glitch in our CSS.

(In reply to Julien Wajsberg [:julienw] from comment #0)
> I have no idea how to start the clickthrough again so I can't give a better
> STR.

You can reset privacy.trackingprotection.introCount to be offered the tour again.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I have a fix for this that I will post later.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: MozReview Request: Bug 1264882 - Fix a visual glitch in the TP tour. r?MattN

Review commit: https://reviewboard.mozilla.org/r/46767/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46767/

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8741809 [details]
MozReview Request: Bug 1264882 - Fix a visual glitch in the TP tour. r?MattN

https://reviewboard.mozilla.org/r/46767/#review43459

Hopefully this doesn't conflict with bug 1180186.

::: browser/themes/linux/browser.css:1960
(Diff revision 1)
>  #UITourTooltipButtons {
> +  margin-left: -10px;

Is this trying to override the same style as the Windows stylesheet: https://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css?rev=c285601ae929#2762

If so, can you please copy that comment here too.

Thanks

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Matthew N. [:MattN] (behind on reviews) from comment #6)
> If so, can you please copy that comment here too.

Done, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/23fdf133c101

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/23fdf133c101

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 48.0a1 (2016-04-19) Ubuntu 14.04.