1264883 - [TV] Tab sync last updated is wrong

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Teri Wen [:twen]]

Tab sync should show the right time for last updated. It always displays "{{hours-ago-long}}" as last updated time. 

[Test Steps]
1. Sign in to Firefox account
2. Sync now - tabs checked
3. Go to default page and tap Tab Sync

[Expected result]
Last update: xx hours ago

[Actual result]
Last update: {{hours-ago-long}}

Comment 1

[Teri Wen [:twen]]

Hi Dan,

This is obvious display issue that should be fixed.

Comment 2

[Dan Huang[:danhuang]]

Got it!

Comment 3

[Dan Huang[:danhuang]]

Hi Zibi,

I use i10n plural property from date.en-US.properties to display last update time in tv sync tab.
Example:

    HTML:
        <span data-l10n-args="{'value':5}" data-l10n-id="fxsync-last-updated-more-than-a-day"</span>

    i10n property:
        fxsync-last-updated-more-than-a-day=Last updated: {{days-ago-long}}

In bug 1257905, you move i10n plural property from date.en-US.properties to relativetimeformat.en-US.properties.
Could you give me some advice to correct the code example above?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

You should use mozIntl:

let rtf = new mozIntl.RelativeTimeFormatter(navigator.languages, {
  unit: 'day'
});

rtf.format(-5).then(val => {
  document.l10n.setAttributes(span, 'fxsync-last-updated-more-than-a-day', {
    'daysAgo' : val
  });
});


and in l10n:

fxsync-last-updated-more-than-a-day=Last updated: {{daysAgo}}

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:bug1264883_sync_tab_list_time_string_not_correct > mozilla-b2g:master

Comment 6

[Dan Huang[:danhuang]]

Comment on attachment 8744205 [details] [review]
[gaia] danhuang1202:bug1264883_sync_tab_list_time_string_not_correct > mozilla-b2g:master

Hi Zibi,

Thanks for your advice! 

This patch use mozIntl to transform the time information in sync tab.
Could you help review this patch?

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8744205 [details] [review]
[gaia] danhuang1202:bug1264883_sync_tab_list_time_string_not_correct > mozilla-b2g:master

Sure. Left a comment. RelativeTimeFormat can use unit: bestFit to pick the right unit based on the value of the integer (relative to now in seconds).

Comment 8

[Dan Huang[:danhuang]]

Comment on attachment 8744205 [details] [review]
[gaia] danhuang1202:bug1264883_sync_tab_list_time_string_not_correct > mozilla-b2g:master

Hi Zibi,

I have update unit to 'bestFit' in this patch. It's really helpful!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8744205 [details] [review]
[gaia] danhuang1202:bug1264883_sync_tab_list_time_string_not_correct > mozilla-b2g:master

Looks great!

Comment 10

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/716376290569cb4a1eee81018077a89171ba8db5

Comment 11

[Teri Wen [:twen]]

Verified fixed on simulator. Time displays correctly.