Implement nsIFileWatcherService for non supported platforms

NEW
Assigned to

Status

()

3 years ago
2 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → amarchesini
(Assignee)

Comment 1

3 years ago
Created attachment 8742338 [details] [diff] [review]
polling.patch

This is OK-ish for not supported platforms.
We will never have many files to watch because this component is currently used by the File object only. And only File objects having underlying real file (mainly created from a FilePicker).
Attachment #8742338 - Flags: review?(khuey)
I'm not convinced this is a good idea.  Why don't we just leave them unsupported?
(Assignee)

Comment 3

2 years ago
Unsupported means that if the underlying file changes, we cannot detect it and FileReader, XHR, and other APIs will retrieve wrong data.
Right. That doesn't seem so bad compared to polling the file.
Comment on attachment 8742338 [details] [diff] [review]
polling.patch

Review of attachment 8742338 [details] [diff] [review]:
-----------------------------------------------------------------

The code is fine, but I don't think we should land this, which I'll show by setting r+ and sr-.  If others think we should land the code they can overrule me :)
Attachment #8742338 - Flags: superreview-
Attachment #8742338 - Flags: review?(khuey)
Attachment #8742338 - Flags: review+
(Assignee)

Updated

2 years ago
Blocks: 660148
You need to log in before you can comment on or make changes to this bug.