1264979 - Implement nsIFileWatcherService for non supported platforms

Status: NEW

(Toolkit :: General, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: polling.patch

This is OK-ish for not supported platforms.
We will never have many files to watch because this component is currently used by the File object only. And only File objects having underlying real file (mainly created from a FilePicker).

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm not convinced this is a good idea.  Why don't we just leave them unsupported?

Comment 3

[Andrea Marchesini [:baku]]

Unsupported means that if the underlying file changes, we cannot detect it and FileReader, XHR, and other APIs will retrieve wrong data.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Right. That doesn't seem so bad compared to polling the file.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8742338 [details] [diff] [review]
polling.patch

Review of attachment 8742338 [details] [diff] [review]:
-----------------------------------------------------------------

The code is fine, but I don't think we should land this, which I'll show by setting r+ and sr-.  If others think we should land the code they can overrule me :)