1264989 - Debugger search box should show Ctrl+f instead of Crtl+P

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P3)

Description

[Jens]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160325004403

Steps to reproduce:

Created after discussion at https://bugzilla.mozilla.org/show_bug.cgi?id=1263104#c11

Just started Nightly and saw that in the Debugger it now says "Search scripts (Ctrl+P)", see screenshot at https://bug1263104.bmoattachments.org/attachment.cgi?id=8741779


Actual results:

1. Ctrl+f still works, so I don't understand why its handled inconsistent here. It should be Ctrl+f everywhere
2. Nit: Again not capitilized ("Search Scripts" like it is for other naming conventions).


Expected results:

So, it should be changed to: "Search Scripts (Ctrl+f)" (I think small capital f is more appropriate than F - there are really user who think they'd need to press <Shift> also otherwise). Surfacing this shortcut is a good idea, though (should be visible to user in each search box imho).

Comment 1

[YF (Yang)]

Ctrl+F is "Find in this file" for the view, added the "#" to search box and focus. Ctrl+P is focus and popup the instruction box.

Comment 2

[Jens]

Attachment: Inconsistencies.png

My humble opinion:

1. The most important Shortcut should be Ctrl+F. Hence, please swap "Ctrl+F" and "Ctrl+P". I learnt that each panel has its own search box technically (and also personally its done by different people). But for the end, it is just one search box that sits in the right top and it is very irritating if these do behave similar.

2. See attached Screenshot, one time it is "Filter scripts", another it is "Search scripts".

3. While we're at it ;) The "#" for "Find in this file" is a bit unfortunate, because in the Inspector search it is a totally different meaning (Searches for IDs). Confusing for beginners. I would propose "%" for current file: % does not have the ambiguity like # and is also used in vim for "current file"

Comment 3

[Jens]

Got it now (after using the devtools and especially its debugger for 1 year now ;) "Filter scripts" (or its type "Search scripts") has not much to do with searching and does something different than !, # or @ operators: It opens a file. Maybe the Ctrl+P functionality should be moved to the leftside "Sources" Panel.

Comment 4

[Eddy Bruel [:ejpbruel]]

UI papercut. Marking this as P3. Leaving it up to James whether or not to accept this as a bug.

Comment 5

[James Long (:jlongster)]

Yeah, I think a better placeholder would be "Filter scripts". I will accept a patch that simply changes that string, but we aren't going to change any more of that because the current debugger is on feature freeze. We are current rewriting the debugger frontend and things like searching/filtering will be a *lot* more intuitive.

Comment 6

[Jason Laster [:jlast]]

this is for the old ui