1265000 - add telemetry probe for dom.max_script_run_time pref

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Chris H-C :chutten]

Attachment: MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe

Users who have this pref set to a non-default value have a different slow
script experience than the others.

This preference is generally set as a flag: it is only ever changed at most
one time in a profile, so it shouldn't appreciably increase subsession splits.

Review commit: https://reviewboard.mozilla.org/r/46799/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46799/

Comment 2

[Chris H-C :chutten]

ni? bsmedberg for data review.

Comment 3

[Benjamin Smedberg]

data-review+

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe

https://reviewboard.mozilla.org/r/46799/#review43369

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a540ef0da2c0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a540ef0da2c0

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Felipe, Chris, as you already know, we need this uplifted to Aurora 47 before e10s experiment kicks off in 47.0b1. Could you please verify we are seeing the data that we should be on Nightly channel before uplifting to Aurora? Thanks in advance for the due diligence.

Comment 8

[Chris H-C :chutten]

Data's coming in: https://gist.github.com/chutten/c735573cf50a1aea7bbb099948f3440f

Comment 9

[Chris H-C :chutten]

Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe

Approval Request Comment
[Feature/regressing bug #]: not a feature nor a regression, though bug 1260769 contains the rationale why we need this additional measure.
[User impact if declined]: Without this we won't be able to measure the impact of the max_script_run_time pref on the SLOW_SCRIPT_PAGE_COUNT e10s release criterion
[Describe test coverage new/current, TreeHerder]: None. Just adding a field to the schema. Though I did throw it through a trybuild just for fun (see above)
[Risks and why]: Minimal to none. Just adding an entry to a well-used map.
[String/UUID change made/needed]: None.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe

New telemetry probe that was verified on Nightly, Aurora47+

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/382d3777ad40