Closed Bug 1265000 Opened 9 years ago Closed 9 years ago

add telemetry probe for dom.max_script_run_time pref

Categories

(Firefox :: General, defect)

48 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox46 --- wontfix
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: blassey, Assigned: chutten)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Users who have this pref set to a non-default value have a different slow script experience than the others. This preference is generally set as a flag: it is only ever changed at most one time in a profile, so it shouldn't appreciably increase subsession splits. Review commit: https://reviewboard.mozilla.org/r/46799/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46799/
Attachment #8741860 - Flags: review?(felipc)
ni? bsmedberg for data review.
Flags: needinfo?(benjamin)
data-review+
Flags: needinfo?(benjamin)
Attachment #8741860 - Flags: review?(felipc) → review+
Comment on attachment 8741860 [details] MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe https://reviewboard.mozilla.org/r/46799/#review43369
Keywords: checkin-needed
Assignee: felipc → chutten
Version: unspecified → 48 Branch
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Hi Felipe, Chris, as you already know, we need this uplifted to Aurora 47 before e10s experiment kicks off in 47.0b1. Could you please verify we are seeing the data that we should be on Nightly channel before uplifting to Aurora? Thanks in advance for the due diligence.
Flags: needinfo?(felipc)
Flags: needinfo?(chutten)
Flags: needinfo?(felipc)
Flags: needinfo?(chutten)
Comment on attachment 8741860 [details] MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe Approval Request Comment [Feature/regressing bug #]: not a feature nor a regression, though bug 1260769 contains the rationale why we need this additional measure. [User impact if declined]: Without this we won't be able to measure the impact of the max_script_run_time pref on the SLOW_SCRIPT_PAGE_COUNT e10s release criterion [Describe test coverage new/current, TreeHerder]: None. Just adding a field to the schema. Though I did throw it through a trybuild just for fun (see above) [Risks and why]: Minimal to none. Just adding an entry to a well-used map. [String/UUID change made/needed]: None.
Attachment #8741860 - Flags: approval-mozilla-aurora?
Comment on attachment 8741860 [details] MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe New telemetry probe that was verified on Nightly, Aurora47+
Attachment #8741860 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: