Closed
Bug 1265000
Opened 9 years ago
Closed 9 years ago
add telemetry probe for dom.max_script_run_time pref
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
People
(Reporter: blassey, Assigned: chutten)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Felipe
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Users who have this pref set to a non-default value have a different slow
script experience than the others.
This preference is generally set as a flag: it is only ever changed at most
one time in a profile, so it shouldn't appreciably increase subsession splits.
Review commit: https://reviewboard.mozilla.org/r/46799/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46799/
Attachment #8741860 -
Flags: review?(felipc)
Updated•9 years ago
|
Attachment #8741860 -
Flags: review?(felipc) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe
https://reviewboard.mozilla.org/r/46799/#review43369
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Assignee: felipc → chutten
Keywords: checkin-needed
Updated•9 years ago
|
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Hi Felipe, Chris, as you already know, we need this uplifted to Aurora 47 before e10s experiment kicks off in 47.0b1. Could you please verify we are seeing the data that we should be on Nightly channel before uplifting to Aurora? Thanks in advance for the due diligence.
Flags: needinfo?(felipc)
Flags: needinfo?(chutten)
Assignee | ||
Comment 8•9 years ago
|
||
Data's coming in: https://gist.github.com/chutten/c735573cf50a1aea7bbb099948f3440f
Flags: needinfo?(felipc)
Flags: needinfo?(chutten)
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe
Approval Request Comment
[Feature/regressing bug #]: not a feature nor a regression, though bug 1260769 contains the rationale why we need this additional measure.
[User impact if declined]: Without this we won't be able to measure the impact of the max_script_run_time pref on the SLOW_SCRIPT_PAGE_COUNT e10s release criterion
[Describe test coverage new/current, TreeHerder]: None. Just adding a field to the schema. Though I did throw it through a trybuild just for fun (see above)
[Risks and why]: Minimal to none. Just adding an entry to a well-used map.
[String/UUID change made/needed]: None.
Attachment #8741860 -
Flags: approval-mozilla-aurora?
Comment on attachment 8741860 [details]
MozReview Request: bug 1265000 - Record dom.max_script_run_time pref in Telemetry Environment data=bsmedberg r?felipe
New telemetry probe that was verified on Nightly, Aurora47+
Attachment #8741860 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•