Closed
Bug 1265017
Opened 8 years ago
Closed 8 years ago
Make Bookmarks > "Other Bookmarks" open a sub menu and move it after "Bookmarks Toolbar"
Categories
(Firefox :: Bookmarks & History, defect, P4)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
1.66 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
For consistency with the bookmarks menu button, we should make Bookmarks > "Other Bookmarks" open a sub menu rather than open the library, and move it after "Bookmarks Toolbar".
Attachment #8741867 -
Flags: review?(mak77)
Comment 1•8 years ago
|
||
Comment on attachment 8741867 [details] [diff] [review] patch Review of attachment 8741867 [details] [diff] [review]: ----------------------------------------------------------------- There is one problem with having unsorted as a menu, that is menus performance with thousands of menuitems is not great at all. On the other side, we are already doing this in the menu button.
Attachment #8741867 -
Flags: review?(mak77) → review+
Updated•8 years ago
|
Priority: -- → P4
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf1a41abcb3e
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1818ce9afc9b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•8 years ago
|
QA Whiteboard: [good first verify]
Comment 5•8 years ago
|
||
I have reproduced this bug with Firefox Release 47.0.1 ( 2016-06-23 ) on Windows 7, 64 Bit. The Bug's fix is now verified on Latest Beta 48.0b7. Build ID 20160711002726 User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [good first verify] → [good first verify][bugday-20160713]
You need to log in
before you can comment on or make changes to this bug.
Description
•