1265019 - Lightning can not handle multiple freebusy providers

Status: NEW

(Calendar :: Internal Components, defect)

Description

[Moritz Strübe]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160407164938

Steps to reproduce:

Subscribe to multiple calendars that provide freebusy information. 


Actual results:

The freebusy-Information is overwritten. Thus if the provider that actually has the information answers last you can view the freebusy information. If a provider that has no freebusy information, answers last the information shows up and gets overwritten immediately.


Expected results:

The merged information of all freebusy provides should be shown.

Comment 1

[Moritz Strübe]

Attachment: Save and show the results of all freebusy providers

I'm no js expert, but this is tested and fixes the issue.

Comment 2

[diesmo]

Hi, This behaviour seems to be linked with Bug 428035.

Comment 3

[Moritz Strübe]

@diesmo: No it isn't. Bug 428035 is about asking the same freebusy provider for each calender from the same server. This bug is about asking all freebusy providers and only using the latest answer. Thus overwriting the answers from the _other_ providers.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks for the patch, generally this looks right to me. I'm slightly concerned about how this should work when multiple freebusy providers are reporting overlapping results, could you test that case?

Also, it would be great to have a unit test for this. I'm happy to help you work on this if you like.

Comment 5

[Merome]

TB 52.1.0 / Lightning 5.4.1 on Windows 7
Using DAVMail to access Exchange 2007 with TB, free/busy display works if I have only one calendar on Lightning.
Adding a calendar to lightning breaks the free/busy display (it shows up, then disapears).

Is there a way to get rid of this annoying bug ?

Comment 6

[Moritz Strübe]

@Merome: Yes, you can apply my patch on the lightning folder. Unfortunately I currently don't have the time to verify possible problems with someone being on two calenders with overlapping appointments (it's on my todo). If you are willing to check the possible issues mentioned in comment 4, I'm willing to provide you a patched lightning.

Comment 7

[Merome]

Hmm. I'm not familiar with patching of TB / Lightning
How am I supposed to do that ?

I tried to modify calFreeBusyService.js manually on my TB installation, but, it doesn't seem to have any effect.
Even if I introduce intentionnally syntax error on js code, nothing happen.
Should I compile or build some stuff somewhere ?

Comment 8

[Moritz Strübe]

@Merome: You need to edit the plugin in your profile folder. If add a syntax error, this breaks lightning pretty badly. In my case I added "asdasfasf" instead of "allresults: [],".

Comment 9

[Merome]

Ok, it works !
Now trying to figure out the case described on comment 4.
Don't know if I can reproduce this...