Closed Bug 1265036 Opened 8 years ago Closed 8 years ago

Change Buffer::try_realloc() crash to an OOM abort

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Keywords: assertion, regression)

Crash Data

Attachments

(1 file)

I see 8 of these crashes in the content process in the last week. Bill, is this something that we should be concerned about? Maybe it is a dupe of one of the other regressions from your patch.
Flags: needinfo?(wmccloskey)
Keywords: assertion, crash
Keywords: regression
It looks like an OOM. We're asking for more memory and not getting it. Maybe I should use NS_ABORT_OOM here?
Flags: needinfo?(wmccloskey)
I'd just switch from realloc to moz_xrealloc, which I think is infallible, so it will annotate everything correctly. That's what Kan-ru used in Pickle::Resize().
Oh, right, but you want to survive a failure sometimes. Yeah, NS_ABORT_OOM would be good.
Keywords: crash
Summary: Crash in Buffer::try_realloc() release assert → Change Buffer::try_realloc() crash to an OOM abort
Attachment #8742050 - Flags: review?(wmccloskey)
Assignee: nobody → continuation
Attachment #8742050 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/1a309a682f19
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.