1265054 - Tools / Sync Now on menu bar does nothing if sync password is reset

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[prikolist]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160123151951

Steps to reproduce:

1. Reset Firefox sync password
(not 100% if I then tried to enter it and mistyped it or forgot to enter it into preferences at all)
2. Click Tools/Sync Now on the menu bar
3. Note that nothing happens
4. Click the Sync (refresh icon) on the address/main toolbar - instantly see a message that Sync didn't work with an exclamation mark over the three-line button
5. Update sync settings with correct password
6. Either way to Sync works afterwards


Actual results:

Silent failure to sync


Expected results:

Some notification of failure to sync because of incorrect password when using the menu bar

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I can't reproduce this.  Steps (2) and (4) should be identical and both cause Sync to (eventually) determine the password was wrong, and as soon as it does, the UI updates to reflect this state (and the "tools" menu also updates at the same time.) In my testing, step (2) alone is enough for Sync to determine the password is wrong - but it may take a number of seconds. Is it possible that you didn't wait long enough after step (2) to notice that it caused the state to change?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

prikolist, are you still able to reproduce this given the information in comment 8?

Comment 3

[prikolist]

Well I'm not getting it anymore - now it changes from "Sync Now" to "Reconnect To Sync". But I think I've updated Firefox during this time, based on the fact that the toolbar sync button moved under the three-line drop down menu. Now the drop-down refresh button doesn't alert me to a sync problem (it threw up some kind of yellow exclamation sign in a triangle alert when I reported the original bug). So the only way to tell you've lost sync - if you have menu bar hidden as per default settings - is if you bother to hover mouse long enough to read the mouseover text that now says "Reconnect to sync" instead of "Last sync at [timestamp]". I guess in all that interface reconfiguration the original issue disappeared. I wish you'd do less interface changes and focus on making one iteration actually bug-free *grumbles*