Move urlbar-related tests into the urlbar directory (out of general)

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks 1 bug, {meta})

Trunk
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Pretty much what it says in the summary. See the blocking bug for reasoning.
Assignee

Comment 2

3 years ago
Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46845/diff/1-2/
Assignee

Comment 3

3 years ago
(In reply to :Gijs Kruitbosch from comment #2)
> Comment on attachment 8741928 [details]
> MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar
> directory, r?adw
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/46845/diff/1-2/

browser_bug495058.js now went from intermittent to perma-orange. I'll have to try to figure out what's wrong there - needless to say it passes locally on OS X, at least... not sure what's up on Linux that would make a difference there. :-\
Assignee

Comment 4

3 years ago
(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > Comment on attachment 8741928 [details]
> > MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar
> > directory, r?adw
> > 
> > Review request updated; see interdiff:
> > https://reviewboard.mozilla.org/r/46845/diff/1-2/
> 
> browser_bug495058.js now went from intermittent to perma-orange. I'll have
> to try to figure out what's wrong there - needless to say it passes locally
> on OS X, at least... not sure what's up on Linux that would make a
> difference there. :-\

I can't reproduce locally, not even with a debug build from mozilla-central running these tests... Going to do some more trypushes:

Same thing on current fx-team tip to see if that helps:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=886dc1dde221

moving back the test:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=8eab4e0d5b52

not running all the other tests:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=10844a45ce8c
Assignee

Comment 5

3 years ago
(In reply to :Gijs Kruitbosch from comment #4)
> I can't reproduce locally, not even with a debug build from mozilla-central
> running these tests... Going to do some more trypushes:

All of these were also orange. :-\

I assume that means my changes to the test are just wrong, so here's a run with the test changes reverted, and still running the test as the first test in the bunch:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=73fd043a0218

If that's busted too, that effectively means that something in the current set of browser/base/content/test/general tests that's run before it is making it pass, but it wouldn't be passing otherwise. :-\
Assignee

Comment 7

3 years ago
(In reply to :Gijs Kruitbosch from comment #6)
> remote:  
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dde217d58f0

Well, that was clownshoes... here's another attempt:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e138330027b
Assignee

Comment 8

3 years ago
Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46845/diff/2-3/
Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

https://reviewboard.mozilla.org/r/46845/#review44911

Thanks Gijs.
Attachment #8741928 - Flags: review?(adw) → review+

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b0b5fc24d37b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.