1265055 - Move urlbar-related tests into the urlbar directory (out of general)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[:Gijs (he/him)]

Pretty much what it says in the summary. See the blocking bug for reasoning.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

Review commit: https://reviewboard.mozilla.org/r/46845/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46845/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46845/diff/1-2/

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> Comment on attachment 8741928 [details]
> MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar
> directory, r?adw
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/46845/diff/1-2/

browser_bug495058.js now went from intermittent to perma-orange. I'll have to try to figure out what's wrong there - needless to say it passes locally on OS X, at least... not sure what's up on Linux that would make a difference there. :-\

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > Comment on attachment 8741928 [details]
> > MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar
> > directory, r?adw
> > 
> > Review request updated; see interdiff:
> > https://reviewboard.mozilla.org/r/46845/diff/1-2/
> 
> browser_bug495058.js now went from intermittent to perma-orange. I'll have
> to try to figure out what's wrong there - needless to say it passes locally
> on OS X, at least... not sure what's up on Linux that would make a
> difference there. :-\

I can't reproduce locally, not even with a debug build from mozilla-central running these tests... Going to do some more trypushes:

Same thing on current fx-team tip to see if that helps:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=886dc1dde221

moving back the test:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=8eab4e0d5b52

not running all the other tests:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=10844a45ce8c

Comment 5

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #4)
> I can't reproduce locally, not even with a debug build from mozilla-central
> running these tests... Going to do some more trypushes:

All of these were also orange. :-\

I assume that means my changes to the test are just wrong, so here's a run with the test changes reverted, and still running the test as the first test in the bunch:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=73fd043a0218

If that's busted too, that effectively means that something in the current set of browser/base/content/test/general tests that's run before it is making it pass, but it wouldn't be passing otherwise. :-\

Comment 6

[:Gijs (he/him)]

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dde217d58f0

Comment 7

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #6)
> remote:  
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dde217d58f0

Well, that was clownshoes... here's another attempt:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e138330027b

Comment 8

[:Gijs (he/him)]

Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46845/diff/2-3/

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 8741928 [details]
MozReview Request: Bug 1265055 - move a bunch of tests to the urlbar directory, r?adw

https://reviewboard.mozilla.org/r/46845/#review44911

Thanks Gijs.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b0b5fc24d37b

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b0b5fc24d37b