Error building buildconfig.html with MSVS2015 - 27:00.25 mozbuild.preprocessor.Error: ('e:\\dev\\fx-team\\toolkit\\content\\buildconfig.html', 46, 'UNDEFINED_VAR', 'CC')

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: Gijs, Unassigned)

Tracking

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(3 attachments)

Reporter

Description

3 years ago
27:00.24 Traceback (most recent call last):
27:00.24   File "e:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module_as_main
27:00.24     "__main__", fname, loader, pkg_name)
27:00.24   File "e:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
27:00.24     exec code in run_globals
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\action\jar_maker.py", line 17, in <module>
27:00.24     sys.exit(main(sys.argv[1:]))
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\action\jar_maker.py", line 13, in main
27:00.24     return mozbuild.jar.main(args)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\jar.py", line 597, in main
27:00.24     jm.makeJar(infile, options.d)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\jar.py", line 333, in makeJar
27:00.24     self.processJarSection(info, jardir)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\jar.py", line 388, in processJarSection
27:00.24     self._processEntryLine(e, outHelper, jf)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\jar.py", line 462, in _processEntryLine
27:00.24     pp.do_include(inf)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 776, in do_include
27:00.24     self.handleLine(l)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 554, in handleLine
27:00.24     self.write(aLine)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 435, in write
27:00.24     filteredLine = self.applyFilters(aLine)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 410, in applyFilters
27:00.24     aLine = f[1](aLine)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 732, in filter_substitution
27:00.24     return self.varsubst.sub(repl, aLine)
27:00.24   File "e:\dev\fx-team\python\mozbuild\mozbuild\preprocessor.py", line 730, in repl
27:00.24     raise Preprocessor.Error(self, 'UNDEFINED_VAR', varname)
27:00.25 mozbuild.preprocessor.Error: ('e:\\dev\\fx-team\\toolkit\\content\\buildconfig.html', 46, 'UNDEFINED_VAR', 'CC')
27:00.25 e:/dev/fx-team/config/rules.mk:1162: recipe for target 'libs' failed
27:00.25 mozmake.EXE[5]: *** [libs] Error 1
27:00.25 e:/dev/fx-team/config/recurse.mk:79: recipe for target 'toolkit/content/libs' failed
27:00.25 mozmake.EXE[4]: *** [toolkit/content/libs] Error 2
27:00.25 e:/dev/fx-team/config/recurse.mk:32: recipe for target 'libs' failed
27:00.25 mozmake.EXE[3]: *** [libs] Error 2
27:00.25 e:/dev/fx-team/config/rules.mk:539: recipe for target 'default' failed
27:00.25 mozmake.EXE[2]: *** [default] Error 2
27:00.25 e:/dev/fx-team/client.mk:407: recipe for target 'realbuild' failed
27:00.25 mozmake.EXE[1]: *** [realbuild] Error 2
27:00.25 client.mk:168: recipe for target 'build' failed
27:00.25 mozmake.EXE: *** [build] Error 2
27:00.28 237 compiler warnings present.
2


This being from a terminal created by latest mozilla-build's start-msvc2015.bat (not the x64 version).
Reporter

Comment 1

3 years ago
Backing out bug 1260327 locally fixes this. Mike, any idea what I'm doing wrong and/or if we need some kind of follow-up fix for Windows?
Blocks: 1260327
Flags: needinfo?(mh+mozilla)
can you paste the output of `mach build -v`?
Flags: needinfo?(mh+mozilla)
Reporter

Comment 3

3 years ago
Posted file mach build -v
I can't get you all of it because ./mach show-log just gives me errors saying the log file doesn't exist (which indeed it does not). But hopefully this is enough?
Flags: needinfo?(mh+mozilla)
So here's the command line that fails:
e:/dev/fx-team/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.jar_maker   -d ../../dist/bin -t e:/dev/fx-team -f flat  --relativesrcdir=toolkit/content -c e:/dev/fx-team/toolkit/content/en-US -DCXXFLAGS=' -TP -nologo -wd5026 -wd5027 -Zc:sizedDealloc- -Zc:threadSafeInit- -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4819 -wd4595 -we4553 -GR-  -Zi -O1 -Oi -Oy ' -DCPPFLAGS=''  -DNDEBUG=1 -DTRIMMED=1 -Dtarget=i686-pc-mingw32 -DMOZ_CONFIGURE_OPTIONS=MOZILLABUILD=E:\mozilla-build\ -DCC=e:/MSVS2015/VC/BIN/amd64_x86/cl.EXE -DCC_VERSION=1900 -DCXX=e:/MSVS2015/VC/BIN/amd64_x86/cl.EXE -DCXX_VERSION=1900 '-DCFLAGS=-TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4244 -wd4267 -wd4819 -we4553' -DUSE_STLPORT -DTOPOBJDIR=e:/dev/fx-team/obj-i686-pc-mingw32 -DA11Y_LOG=1 -DACCESSIBILITY=1 -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DD_INO=d_ino -DE10S_TESTING_ONLY=1 -DEARLY_BETA_OR_EARLIER=1 -DENABLE_INTL_API=1 -DENABLE_MARIONETTE=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DEXPOSE_INTL_API=1 -DFIREFOX_VERSION=48.0a1 -DFORCE_PR_LOG=1 -DGTEST_HAS_RTTI=0 -DHAVE_FORCEINLINE=1 -DHAVE_INTTYPES_H=1 -DHAVE_IO_H=1 -DHAVE_ISATTY=1 -DHAVE_LOCALECONV=1 -DHAVE_MALLOC_H=1 -DHAVE_SEH_EXCEPTIONS=1 -DHAVE_STDINT_H=1 -DHAVE_UINT64_T=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR=const -DMOZILLA_UAVERSION='"48.0"' -DMOZILLA_VERSION='"48.0a1"' -DMOZILLA_VERSION_U=48.0a1 -DMOZ_ACTIVITIES=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"48.0a1"' -DMOZ_B2G_OS_NAME='""' -DMOZ_B2G_VERSION='"1.0.0"' -DMOZ_BUILD_APP=browser -DMOZ_CONTENT_SANDBOX=1 -DMOZ_CRASHREPORTER=1 -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DMOZ_CRASHREPORTER_INJECTOR=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_DIRECTSHOW=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_SUFFIX='".dll"' -DMOZ_EME=1 -DMOZ_ENABLE_PROFILER_SPS=1 -DMOZ_ENABLE_SIGNMAR=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_FEEDS=1 -DMOZ_FFVPX=1 -DMOZ_FMP4=1 -DMOZ_GAMEPAD=1 -DMOZ_GMP_SANDBOX=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_JSDOWNLOADS=1 -DMOZ_LIBAV_FFT=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.nightly -DMOZ_MAINTENANCE_SERVICE=1 -DMOZ_MEMORY=1 -DMOZ_MEMORY_WINDOWS=1 -DMOZ_MSVC_STL_WRAP_RAISE=1 -DMOZ_PAY=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PERMISSIONS=1 -DMOZ_PHOENIX=1 -DMOZ_PLACES=1 -DMOZ_RAW=1 -DMOZ_REPLACE_MALLOC=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SECUREELEMENT=1 -DMOZ_SERVICES_CLOUDSYNC=1 -DMOZ_SERVICES_COMMON=1 -DMOZ_SERVICES_CRYPTO=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_SOCIAL=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_URL_CLASSIFIER=1 -DMOZ_USER_DIR='"Mozilla"' -DMOZ_VORBIS=1 -DMOZ_VPX_ERROR_CONCEALMENT=1 -DMOZ_VPX_NO_MEM_REPORTING=1 -DMOZ_WEBGL_CONFORMANT=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WINSDK_MAXVER=0x0A000000 -DMOZ_WINSDK_TARGETVER=0x06030000 -DMOZ_WMF=1 -DMOZ_XUL=1 -DMSVC_HAS_DIA_SDK=1 -DNIGHTLY_BUILD=1 -DNOMINMAX=1 -DNO_NSPR_10_SUPPORT=1 -DNS_ENABLE_TSF=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86-msvc"' -DUSE_SKIA=1 -DUSE_SKIA_GPU=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVPX_X86_ASM=1 -DWIN32=1 -DWIN32_LEAN_AND_MEAN=1 -DWINVER=0x502 -DXP_WIN=1 -DXP_WIN32=1 -DX_DISPLAY_MISSING=1 -D_CRT_NONSTDC_NO_WARNINGS=1 -D_CRT_SECURE_NO_WARNINGS=1 -D_USE_MATH_DEFINES=1 -D_VARIADIC_MAX=10 -D_WIN32_IE=0x0603 -D_WIN32_WINNT=0x502 -D_WINDOWS=1 -D_X86_=1 -DAB_CD=en-US e:/dev/fx-team/toolkit/content/jar.mn

... and the problem is here:
-DMOZ_CONFIGURE_OPTIONS=MOZILLABUILD=E:\mozilla-build\ -DCC=e:/MSVS2015/VC/BIN/amd64_x86/cl.EXE

Where MOZ_CONFIGURE_OPTIONS is
a) probably incomplete
b) not quoted properly
Flags: needinfo?(mh+mozilla)
Can you attach $objdir/toolkit/content/backend.mk?
Reporter

Comment 6

3 years ago
Posted file backend.mk
Can you attach $objdir/config.status?
(In reply to Mike Hommey [:glandium] from comment #7)
> Can you attach $objdir/config.status?

No need for it, I found what's wrong.
Reporter

Comment 10

3 years ago
Comment on attachment 8742042 [details]
MozReview Request: Bug 1265063 - Fix the shell quoting regexp to properly match backslashes. r?gps

This fixes my build.
Attachment #8742042 - Flags: feedback+
Comment on attachment 8742042 [details]
MozReview Request: Bug 1265063 - Fix the shell quoting regexp to properly match backslashes. r?gps

https://reviewboard.mozilla.org/r/46909/#review43771

Oy.
Attachment #8742042 - Flags: review?(gps) → review+

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/adf8fb3e8d48
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

6 months ago
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.