Separator em dash is incorrectly shown for bookmark keyword searches

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Address Bar
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I have a bookmark keyword "b" for going to Bugzilla bugs.  Typing "b 12345" ends up looking like this, with a dash is shown at the end:

bugzilla.mozilla.org: 12345 --
(Assignee)

Comment 1

2 years ago
Created attachment 8741930 [details]
MozReview Request: Bug 1265066 - Hide the separator em dash in bookmark keyword awesomebar results. r?mak

Review commit: https://reviewboard.mozilla.org/r/46849/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46849/
Attachment #8741930 - Flags: review?(mak77)
(Assignee)

Comment 2

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a13a484b9480
(Assignee)

Comment 3

2 years ago
Comment on attachment 8741930 [details]
MozReview Request: Bug 1265066 - Hide the separator em dash in bookmark keyword awesomebar results. r?mak

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46849/diff/1-2/
(Assignee)

Comment 4

2 years ago
Test fixes due to re-setting the type attribute:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7058cf4d38c7
(Assignee)

Comment 5

2 years ago
The leaks on try are due to an unrelated commit that was backed out of fx-team shortly after I refreshed my local copy.
Comment on attachment 8741930 [details]
MozReview Request: Bug 1265066 - Hide the separator em dash in bookmark keyword awesomebar results. r?mak

https://reviewboard.mozilla.org/r/46849/#review44185
Attachment #8741930 - Flags: review?(mak77) → review+

Comment 7

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/0ae340c9ece2

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0ae340c9ece2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Comment 9

a year ago
I have reproduced this with Nightly 48.0a1 (2016-04-16) on Elementary OS 64bit. 

This fix is now verified on Firefox release 48.0

Build ID 	20160726073904
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

[bugday-20160803]
You need to log in before you can comment on or make changes to this bug.