wasmTextToBinary cannot parse comments in the code

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: yury, Assigned: yury)

Tracking

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Currently we don't support comments in the wasmTextToBinary. However we are trying to use this function in the binaryen's spidermonkify.py script (and binaryen can produce code with comments).

Also, I'm trying to add some basic support of debug info annotations as comments, so it will be useful to just ignore them in SM.
Comment on attachment 8742012 [details] [diff] [review]
Adds s-expr comments support for wasmTextToBinary.

Review of attachment 8742012 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8742012 - Flags: review?(sunfish) → review+

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f58b6c6a39f9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.