Closed Bug 1265133 Opened 7 years ago Closed 7 years ago

wasmTextToBinary cannot parse comments in the code

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file)

Adds s-expr comments support for wasmTextToBinary.
4.50 KB, patch
sunfish
: review+
Details | Diff | Splinter Review 
Currently we don't support comments in the wasmTextToBinary. However we are trying to use this function in the binaryen's spidermonkify.py script (and binaryen can produce code with comments).

Also, I'm trying to add some basic support of debug info annotations as comments, so it will be useful to just ignore them in SM.
Comment on attachment 8742012 [details] [diff] [review]
Adds s-expr comments support for wasmTextToBinary.

Review of attachment 8742012 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8742012 - Flags: review?(sunfish) → review+
https://hg.mozilla.org/mozilla-central/rev/f58b6c6a39f9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.