Closed Bug 1265164 Opened 10 years ago Closed 10 years ago

Always use nsCOMPtrs with getNSSDialogs()

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler
58 bytes, text/x-review-board-request
keeler
: review+
Details
Because nsCOMPtrs let us avoid manual ref counting, which is good.
Comment on attachment 8745919 [details] MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler https://reviewboard.mozilla.org/r/49167/#review46143 Looks good.
Attachment #8745919 - Flags: review?(dkeeler) → review+
Comment on attachment 8745919 [details] MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49167/diff/1-2/
Attachment #8745919 - Attachment description: MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). → MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler
https://hg.mozilla.org/mozilla-central/rev/b05c78b96f10
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: