Closed Bug 1265164 Opened 6 years ago Closed 6 years ago

Always use nsCOMPtrs with getNSSDialogs()

Categories

(Core :: Security: PSM, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

Because nsCOMPtrs let us avoid manual ref counting, which is good.
Comment on attachment 8745919 [details]
MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler

https://reviewboard.mozilla.org/r/49167/#review46143

Looks good.
Attachment #8745919 - Flags: review?(dkeeler) → review+
Comment on attachment 8745919 [details]
MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49167/diff/1-2/
Attachment #8745919 - Attachment description: MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). → MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler
https://hg.mozilla.org/mozilla-central/rev/b05c78b96f10
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.