Closed
Bug 1265164
Opened 7 years ago
Closed 7 years ago
Always use nsCOMPtrs with getNSSDialogs()
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Because nsCOMPtrs let us avoid manual ref counting, which is good.
|
Assignee | |
Comment 1•7 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49167/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49167/
Attachment #8745919 -
Flags: review?(dkeeler)
Comment on attachment 8745919 [details] MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler https://reviewboard.mozilla.org/r/49167/#review46143 Looks good.
Attachment #8745919 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8745919 [details] MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49167/diff/1-2/
Attachment #8745919 -
Attachment description: MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). → MozReview Request: Bug 1265164 - Always use nsCOMPtrs with getNSSDialogs(). r=keeler
|
|
Assignee | |
Comment 4•7 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=6eaf09dabff76c9ab028e1ea04ecc636deed7f53 https://treeherder.mozilla.org/#/jobs?repo=try&revision=edd988960d1f681fde9f9f1e3d16c8e5c9dc5676
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b05c78b96f10
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•