Closed
Bug 1265177
Opened 8 years ago
Closed 8 years ago
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-tooltip-multimessage.js
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 48.0
People
(Reporter: jorgk-bmo, Assigned: aleth)
References
Details
Attachments
(1 file)
First seen 2016-04-16: TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-tooltip-multimessage.js | test-tooltip-multimessage.js::test_tooltips TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run 04:49:01 INFO - SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-tooltip-multimessage.js | test-tooltip-multimessage.js::test_tooltips 04:49:01 INFO - EXCEPTION: Components.classes['@mozilla.org/embedcomp/default-tooltiptextprovider;1'] is undefined 04:49:01 INFO - at: popup.xml line 533 04:49:01 INFO - get_textProvider popup.xml:533 13 04:49:01 INFO - fillInPageTooltip popup.xml:549 15 04:49:01 INFO - test_tooltips test-tooltip-multimessage.js:42 3 04:49:01 INFO - Runner.prototype.wrapper frame.js:585 9 04:49:01 INFO - Runner.prototype._runTestModule frame.js:655 9 04:49:01 INFO - Runner.prototype.runTestModule frame.js:701 3 04:49:01 INFO - Runner.prototype.runTestDirectory frame.js:525 7 04:49:01 INFO - runTestDirectory frame.js:707 3 04:49:01 INFO - Bridge.prototype._execFunction server.js:179 10 04:49:01 INFO - Bridge.prototype.execFunction server.js:183 16 04:49:01 INFO - Session.prototype.receive server.js:283 3 04:49:01 INFO - AsyncRead.prototype.onDataAvailable server.js:88 3 Looks like something changed in M-C to cause this, perhaps bug 1236991.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8742128 -
Flags: review?(philip.chee)
Attachment #8742128 -
Flags: review?(mkmelin+mozilla)
Attachment #8742128 -
Flags: review?(clokep)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09b14130ab02
Updated•8 years ago
|
Attachment #8742128 -
Flags: review?(philip.chee) → review+
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8742128 [details] [diff] [review] Package TooltipTextProvider Review of attachment 8742128 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this review. We don't need to hold up proceedings for this simple change. BTW, thanks a lot for investigating it.
Attachment #8742128 -
Flags: review?(mkmelin+mozilla) → review+
Updated•8 years ago
|
Attachment #8742128 -
Flags: review?(clokep) → review+
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8742128 [details] [diff] [review] Package TooltipTextProvider Please don't call the patch files "."!!
Attachment #8742128 -
Attachment filename: . → 1265177.patch
Reporter | ||
Comment 5•8 years ago
|
||
Thanks Aleth. https://hg.mozilla.org/comm-central/rev/eb24f0689dcb BTW, can you fix your try links. All the ones you post are invalid: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09b14130ab02 Try clicking that. "try" is for Mozilla core.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Comment 6•8 years ago
|
||
Good to see this got fixed so quickly. Hopefully build system work will obviate the need for package/installer manifests in future, they're a pain. :-\ (In reply to Jorg K (GMT+2) from comment #4) > Comment on attachment 8742128 [details] [diff] [review] > Package TooltipTextProvider > > Please don't call the patch files "."!! While I can't speak for Aleth with certainty, this is bzexport's default behaviour when submitting actual commits from your repo. It'd be lovely to have that fixed, but if I'm right this isn't human beings doing it on purpose or anything.
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #6) > > Please don't call the patch files "."!! > > While I can't speak for Aleth with certainty, this is bzexport's default > behaviour when submitting actual commits from your repo. It'd be lovely to > have that fixed, but if I'm right this isn't human beings doing it on > purpose or anything. Yes, that's exactly what happens. There is a bzexport bug filed for this. The try links are also not manually generated, and the extension doesn't seem to know try-c-c yet.
Reporter | ||
Comment 8•8 years ago
|
||
So you're saying that there is some benefit to he had by doing things manually? ;-)
You need to log in
before you can comment on or make changes to this bug.
Description
•