Closed Bug 1265202 Opened 3 years ago Closed 3 years ago

Install mozscreenshots as a temporary add-on

Categories

(Testing :: mozscreenshots, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

mozscreenshots got signed by bug 1250616. It would be more convenient if rather than being signed, they could be installed as temporary addons.

Bug 1251633 was coming up with a general approach (which I don't fully understand) but we can just go back to the attachment 8612148 [details] [diff] [review] approach of installing the extension ourselves.
Comment on attachment 8742091 [details]
MozReview Request: Bug 1265202 - Install mozscreenshots as a temporary add-on. r=bgrins

https://reviewboard.mozilla.org/r/46935/#review43681
Attachment #8742091 - Flags: review?(bgrinstead) → review+
Comment on attachment 8742090 [details]
MozReview Request: Bug 1265202 - Back out changeset ef98cb11ba62 from bug 12506160 which used a signed XPI. r=bgrins

https://reviewboard.mozilla.org/r/46933/#review43683

If that Makefile.in file wasn't added I'd rubber stamp the rest, but I don't know enough about the build system to confidently review that.  Can you find another reviewer?

::: browser/tools/mozscreenshots/mozscreenshots/extension/Makefile.in:7
(Diff revision 1)
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +TEST_EXTENSIONS_DIR = $(DEPTH)/_tests/testing/mochitest/extensions
> +GENERATED_DIRS =  $(TEST_EXTENSIONS_DIR)
> +XPI_PKGNAME = mozscreenshots@mozilla.org

Looks like this file has to do with the xpi, which is being removed, right?  Why's this needed?
Attachment #8742090 - Flags: review?(bgrinstead)
https://reviewboard.mozilla.org/r/46933/#review43683

This is a straight backout so this code was already reviewed during its previous landing.

> Looks like this file has to do with the xpi, which is being removed, right?  Why's this needed?

We still need it as we still need to stage the extension. The test code is pointing to the output from the build system (like it was before the signing change), not the source directory.

Eventually it may be possible to treat the extension files like regular test files that happen to be in a directory structure appropriate for an extension and avoid any preprocessing but that's a separate issue really.
https://hg.mozilla.org/mozilla-central/rev/22d11eca4d25
https://hg.mozilla.org/mozilla-central/rev/dadd3d52a252
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: Mochitest → mozscreenshots
Target Milestone: mozilla48 → ---
You need to log in before you can comment on or make changes to this bug.