Closed Bug 1265207 Opened 7 years ago Closed 7 years ago

Enable ESLint "var-only-at-top-level" rule for PSM tests

Categories

(Core :: Security: PSM, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

... because |let| is generally preferred over |var| in PSM JS.

Non-test code is not in scope for this bug because the changes required would be too numerous (and more complex).
|let| is generally preferred over |var| in PSM JS.

Review commit: https://reviewboard.mozilla.org/r/51463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51463/
Attachment #8750573 - Flags: review?(jjones)
Comment on attachment 8750573 [details]
MozReview Request: Bug 1265207 - Enable ESLint "var-only-at-top-level" rule for PSM tests.

https://reviewboard.mozilla.org/r/51463/#review48749

Tbis looks straightforward and I don't see any issues. Thank you! r=jcj
Attachment #8750573 - Flags: review?(jjones) → review+
https://hg.mozilla.org/mozilla-central/rev/f422f7b5330f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.