Closed Bug 1265211 Opened 4 years ago Closed 4 years ago

Intermittent dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Attestation Certificate signature verified

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: aryx, Assigned: jcj)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

This is in code bug 1244960 landed a day ago.

https://treeherder.mozilla.org/logviewer.html#?job_id=25975054&repo=mozilla-inbound

22:44:10     INFO -  177 INFO SimpleTest START
22:44:10     INFO -  178 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Is loaded correctly
22:44:10     INFO -  179 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: AppID should work from a subdomain
22:44:10     INFO -  180 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: AppID should not work from other domains
22:44:10     INFO -  181 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Empty register requests
22:44:10     INFO -  182 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Non-array register requests
22:44:10     INFO -  183 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Non-array sign requests
22:44:10     INFO -  184 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Non-array for both arguments
22:44:10     INFO -  185 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Empty request
22:44:10     INFO -  186 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Missing challenge
22:44:10     INFO -  187 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Missing version
22:44:10     INFO -  188 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register.html: Invalid version
22:44:10     INFO -  189 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: U2F API endpoint must exist
22:44:10     INFO -  190 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: U2F Register API endpoint must exist
22:44:10     INFO -  191 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: U2F Sign API endpoint must exist
22:44:10     INFO -  192 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: The registration did not error
22:44:10     INFO -  193 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: The registration did not provide registration data
22:44:10     INFO -  194 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Reserved byte is correct
22:44:10     INFO -  195 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Attestation Certificate has correct starting byte
22:44:10     INFO -  196 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Expected Subject
22:44:10     INFO -  197 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Expected Issuer
22:44:10     INFO -  198 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Valid 48 hours (in millis)
22:44:10     INFO -  199 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Data type matches
22:44:10     INFO -  200 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Register challenge matches
22:44:10     INFO -  201 INFO TEST-PASS | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Origins are the same
22:44:10     INFO -  202 INFO TEST-UNEXPECTED-FAIL | dom/u2f/tests/test_frame.html | /tests/dom/u2f/tests/test_frame_register_sign.html: Attestation Certificate signature verified
22:44:10     INFO -      receiveMessage@dom/u2f/tests/test_frame.html:51:7
22:44:10     INFO -      EventListener.handleEvent*@dom/u2f/tests/test_frame.html:57:3
22:44:10     INFO -      Async*@dom/u2f/tests/test_frame.html:21:1
Assignee: nobody → jjones
- The u2futil.js script's verifySignature method was causing an intermittent
  in test_frame_register_sign.html due to incomplete ASN.1 decoding. Since
  we're calready pulling in an ASN.1 parsing library, this changes that code to
  do a complete parse and santizize, which should cover all cases.

Review commit: https://reviewboard.mozilla.org/r/47723/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47723/
Attachment #8743343 - Flags: review?(mgoodwin)
Try run looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=211fd22e9f3e

Marking checkin-needed.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 8743343 [details]
MozReview Request: Bug 1265211 - Fix intermittent U2F Test r?mgoodwin

https://reviewboard.mozilla.org/r/47723/#review45789
Attachment #8743343 - Flags: review?(mgoodwin) → review+
https://hg.mozilla.org/mozilla-central/rev/8a71d1ea7a38
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.