Closed Bug 1265321 Opened 8 years ago Closed 8 years ago

[Widevine] The Widevine plug-in can't be enabled from the "You must enable DRM..." bar

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox47 --- verified
firefox48 --- verified

People

(Reporter: sbadau, Assigned: bytesized)

References

Details

Attachments

(1 file)

[Affected versions]:
Nightly 48.0a1

[Affected platforms]:
Windows 10
Mac OS X 10.9

[Steps to reproduce]:
1. Install the latest Nightly 48.0a1
2. Go to about:addons -> Plugins -> wait for the "Widevine Content Decryption Module provided by Google Inc." plugin to be downloaded and installed
3. Disable the Widevine CDM plugin 
4. Install the User Agent Switcher add-on from:
https://addons.mozilla.org/en-US/firefox/addon/user-agent-switcher-firefox/?src=ss
5. Navigate to Netflix and log in
https://www.netflix.com
6. Choose any video and click on the Play button.
7. Click on the Enable DRM button that is located on the upper bar "You must enable DRM to play some audio or video on this page."


[Expected result]:
The Widevine CDM plugin should be enabled and the video should start playing.

[Actual result]:
The Widevine plugin is not enabled, the "Whoops, something went wrong message" is displayed stating there is a missing component and the upper "You must enable DRM..." bar is displayed over and over.

[Regression range]:
This is not a regression. 

[Additional notes]:
When videos are ran through Primetime CDM and the plug-in is disabled, clicking on the "Enable DRM" button from the upper "You must enable DRM..." bar, enables the plugin.
Additional info for step 4. 
After installing the User Agent Switcher add-on -> select Google Chrome as a Desktop browser.
Kirk: Can you look into this?
Component: Audio/Video: Playback → General
Flags: needinfo?(ksteuber)
Product: Core → Firefox
I will take a look.
Assignee: nobody → ksteuber
Flags: needinfo?(ksteuber)
Attachment #8742571 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8742571 [details]
MozReview Request: Bug 1265321 - Allow widevine plugin to be enabled from the 'You must enable DRM' bar

https://reviewboard.mozilla.org/r/47315/#review44191

::: browser/base/content/browser-eme.js:26
(Diff revision 1)
>          Services.prefs.setBoolPref("media.gmp-eme-adobe.enabled", true);
>        } else if (keySystem == "org.w3.clearkey" &&
>                   Services.prefs.getPrefType("media.eme.clearkey.enabled") &&
>                   !Services.prefs.getBoolPref("media.eme.clearkey.enabled")) {
>          Services.prefs.setBoolPref("media.eme.clearkey.enabled", true);
> +      } else if (keySystem == "com.widevine.alpha" &&

Is "com.widevine.alpha" the only value that we'll want to test for? Or will other values such as "com.widevine.beta" need to be supported in the future? If the latter, please change this to |keySystem.startsWith("com.widevine")| like "com.adobe" above.
Attachment #8742571 - Flags: review?(spohl.mozilla.bugs) → review+
(In reply to Stephen A Pohl [:spohl] (PTO 4/15) from comment #6)
> Is "com.widevine.alpha" the only value that we'll want to test for? Or will
> other values such as "com.widevine.beta" need to be supported in the future?
> If the latter, please change this to |keySystem.startsWith("com.widevine")|
> like "com.adobe" above.

I asked Chris Pearce about this, and he said that he does not expect widevine to use a version string and that using |keySystem == "com.widevine.alpha"| is probably fine.
(In reply to Kirk Steuber [:ksteuber] from comment #7)
> (In reply to Stephen A Pohl [:spohl] (PTO 4/15) from comment #6)
> > Is "com.widevine.alpha" the only value that we'll want to test for? Or will
> > other values such as "com.widevine.beta" need to be supported in the future?
> > If the latter, please change this to |keySystem.startsWith("com.widevine")|
> > like "com.adobe" above.
> 
> I asked Chris Pearce about this, and he said that he does not expect
> widevine to use a version string and that using |keySystem ==
> "com.widevine.alpha"| is probably fine.

Sounds good, thanks.
https://hg.mozilla.org/mozilla-central/rev/7120b9fe3f83
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8742571 [details]
MozReview Request: Bug 1265321 - Allow widevine plugin to be enabled from the 'You must enable DRM' bar

Requesting uplift for Firefox 47.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME support
[User impact if declined]: Widevine CDM will not be able to be enabled by our "you need to enable EME to play this DRM protected video" UI.
[Describe test coverage new/current, TreeHerder]: Not sure how much testing we have for this.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8742571 - Flags: approval-mozilla-aurora?
Comment on attachment 8742571 [details]
MozReview Request: Bug 1265321 - Allow widevine plugin to be enabled from the 'You must enable DRM' bar

Widevine related uplifts were pre-approved.
Attachment #8742571 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I can confirm the issue no longer reproduces on Windows 7, Windows 10 and Mac OS 10.9.5 on Nightly version 48.0a1, build id 20160421030302.
I have tested this issue on:
- Win 7 x32 and x64, 8 x64, 8.1 x32, 10 x64
- Mac OS 10.11 and 10.9 

With the latest Nightly(49.0a1, Build ID: 20160426044609), latest Aurora(48.0a2, Build ID: 20160427004105) and 
latest Beta (47.0b1, Build ID: 20160425205003).
I can confirm that this issue is no longer reproducible.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.