Enable blocking of uncommon downloads

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Downloads Panel
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Trunk
Firefox 48
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
After bug 1198181 and any other relevant dependencies are met, we should enable the blocking of uncommon downloads.
(Assignee)

Updated

2 years ago
Depends on: 1265363
(Assignee)

Updated

2 years ago
Depends on: 1265362
(Assignee)

Updated

2 years ago
Depends on: 1265387
(Assignee)

Updated

2 years ago
Blocks: 1019933

Updated

2 years ago
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 48.3 - Apr 25
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [fxprivacy][triage] → [fxprivacy]
(Assignee)

Comment 1

2 years ago
Created attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

Review commit: https://reviewboard.mozilla.org/r/47695/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47695/
Attachment #8743291 - Flags: review?(gpascutto)
(Assignee)

Comment 2

2 years ago
Note that this patch is on top of bug 1033450.
Depends on: 1033450
(Assignee)

Comment 3

2 years ago
Comment on attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

Tryserver build where equivalent functionality can be tested:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e607cf103f08
Attachment #8743291 - Flags: review?(francois)
Comment on attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

https://reviewboard.mozilla.org/r/47695/#review44653

If you rebase this patch, you'll find that the pref needs to be set in `modules/libpref/init/all.js` (thanks to bug 1033450 having landed).
Attachment #8743291 - Flags: review?(francois)
(Assignee)

Comment 5

2 years ago
Comment on attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

As I've noted in comment 2, this patch is already based on bug 1033450 (otherwise it would have looked like a value change instead of a line addition).

We need to make the change in "firefox.js" because we only need to enable this type of blocking in the Desktop version. Other products don't have the required UI.

You can also find a tryserver build linked in comment 3 if you want to test the functionality.
Attachment #8743291 - Flags: review?(francois)
Attachment #8743291 - Flags: review?(gpascutto) → review+
Comment on attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

https://reviewboard.mozilla.org/r/47695/#review44867
Comment on attachment 8743291 [details]
MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp

https://reviewboard.mozilla.org/r/47695/#review44951

As mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1265359#c7 there was a problem landing bug 1033450 so we should wait until that's sorted out.
Attachment #8743291 - Flags: review?(francois)
(Assignee)

Updated

2 years ago
Blocks: 1033450
No longer depends on: 1033450

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a36e52a4543d
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Updated

2 years ago
Blocks: 1266965
You need to log in before you can comment on or make changes to this bug.