Closed
Bug 1265358
Opened 8 years ago
Closed 8 years ago
Enable blocking of uncommon downloads
Categories
(Firefox :: Downloads Panel, defect, P1)
Firefox
Downloads Panel
Tracking
()
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
After bug 1198181 and any other relevant dependencies are met, we should enable the blocking of uncommon downloads.
Updated•8 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 48.3 - Apr 25
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47695/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47695/
Attachment #8743291 -
Flags: review?(gpascutto)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8743291 [details] MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp Tryserver build where equivalent functionality can be tested: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e607cf103f08
Attachment #8743291 -
Flags: review?(francois)
Comment 4•8 years ago
|
||
Comment on attachment 8743291 [details] MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp https://reviewboard.mozilla.org/r/47695/#review44653 If you rebase this patch, you'll find that the pref needs to be set in `modules/libpref/init/all.js` (thanks to bug 1033450 having landed).
Attachment #8743291 -
Flags: review?(francois)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8743291 [details] MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp As I've noted in comment 2, this patch is already based on bug 1033450 (otherwise it would have looked like a value change instead of a line addition). We need to make the change in "firefox.js" because we only need to enable this type of blocking in the Desktop version. Other products don't have the required UI. You can also find a tryserver build linked in comment 3 if you want to test the functionality.
Attachment #8743291 -
Flags: review?(francois)
Updated•8 years ago
|
Attachment #8743291 -
Flags: review?(gpascutto) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8743291 [details] MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp https://reviewboard.mozilla.org/r/47695/#review44867
Comment 7•8 years ago
|
||
Comment on attachment 8743291 [details] MozReview Request: Bug 1265358 - Enable blocking of uncommon downloads. r=gcp https://reviewboard.mozilla.org/r/47695/#review44951 As mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1265359#c7 there was a problem landing bug 1033450 so we should wait until that's sorted out.
Attachment #8743291 -
Flags: review?(francois)
Assignee | ||
Updated•8 years ago
|
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a36e52a4543d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•