Closed Bug 1265362 Opened 4 years ago Closed 4 years ago

Update strings for the new user interface of blocked downloads

Categories

(Firefox :: Downloads Panel, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 48
Iteration:
48.3 - Apr 25
Tracking Status
firefox48 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy] [strings])

Attachments

(9 files)

We should update the strings based on the new interactions defined for blocked downloads.
Blocks: 1265359, 1265358
Whiteboard: [fxprivacy][strings] → [fxprivacy] [strings] [triage]
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 48.3 - Apr 25
Flags: qe-verify-
Whiteboard: [fxprivacy] [strings] [triage] → [fxprivacy] [strings]
Priority: -- → P1
This should land after we have defined the final strings. I'll post a work in progress patch.
Comment on attachment 8743289 [details]
MozReview Request: Bug 1265362 - Update strings for the new user interface of blocked downloads. r=past

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47687/diff/1-2/
This patch updates some of the strings already discussed in bug 1053890 now that we are enabling the blocking of uncommon and potentially unwanted downloads.

For potentially unwanted downloads, there is just a slight formatting change:

"This file is disguised as a helpful download, but it will make unexpected changes to your programs and settings."

The string for uncommon downloads changes more significantly, removing the reference to the website being unfamiliar and potentially dangerous because it isn't necessarily the case, and specifying more clearly the potential threat and that the file can actually be safe to open:

"This file is not commonly downloaded. It may contain a virus or make unexpected changes to your programs and settings, or it may be safe to open."
Comment on attachment 8743289 [details]
MozReview Request: Bug 1265362 - Update strings for the new user interface of blocked downloads. r=past

https://reviewboard.mozilla.org/r/47687/#review44875

I only spotted one tiny thing, but I don't know if there was agreement with Javaun and Matej about the uncommon case. r=me once we are good there.

::: browser/locales/en-US/chrome/browser/downloads/downloads.properties:63
(Diff revision 2)
>  # descending order by the unblockType strings, it is higher for files detected
>  # as malware and lower for uncommon downloads.
>  unblockHeaderUnblock=Are you sure you want to allow this download?
>  unblockHeaderOpen=Are you sure you want to open this file?
>  unblockTypeMalware=This file contains a virus or other malware that will harm your computer.
> -unblockTypePotentiallyUnwanted=This file, disguised as a helpful download, will make unexpected changes to your programs and settings.
> +unblockTypePotentiallyUnwanted2=This file is disguised as a helpful download, but it will make unexpected changes to your programs and settings.

I see "but it can make", not "but it will make" in the doc.
Attachment #8743289 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #5)
> I see "but it can make", not "but it will make" in the doc.

Differently from the uncommon case, the potentially unwanted software has been scanned and determined to actually contain code that will make changes to programs and settings unexpectedly, so these will happen for sure, it's not just a possibility.
It may well make changes, but we can't say for sure that the changes will be unexpected to the user. Some users may be used to downloading bundled software.
For Uncommon, the string we got from Matej is:
==========

This file is not commonly downloaded and may not be safe to open. It may contain a virus or make unexpected changes to your programs and settings.

You can search for an alternate download source or try again later.
=====

This is smoother language. It drops the explicit "or it may be safe", but that is implied in the "it may not be safe to open." We also know from Google that most of the "uncommon" stuff turns out to be malware, so "not safe" will be true far more often than not. We can afford to be more certain here.
One more change to Potentially Unwanted, we have *will* in the patch, we should say "it *can* make unexpected changes..."


================
 This file is disguised as a helpful download, but it can make unexpected changes to your programs and settings.

You can search for an alternate download source or try again later.
(In reply to Javaun Moradi [:javaun] from comment #16)
> This is smoother language. It drops the explicit "or it may be safe", but
> that is implied in the "it may not be safe to open." We also know from
> Google that most of the "uncommon" stuff turns out to be malware, so "not
> safe" will be true far more often than not. We can afford to be more certain
> here.

This definitely shifts the balance of the language towards expressing the concept that uncommon downloads are dangerous, without mentioning that in some cases they may be not. Since we're also using the "may" construct for potentially unwanted downloads, the difference in expressing the different threat levels will now be minimal.

I'll go ahead and land these proposed strings because overall they are a slight improvement over what we have now, although I think they are still sub-optimal and they can be further improved.

I also think the important element for uncommon downloads in Firefox is that the default action will be to open the file. We can always improve the strings later with more balanced language.
https://hg.mozilla.org/mozilla-central/rev/8943b294f4ea
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.