Add a `length` attribute to the OfflineAudioContext

RESOLVED FIXED in Firefox 49

Status

()

Core
Web Audio
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This has the same value as the parameter passed to the construtor.

Spec changes at https://github.com/webaudio/web-audio-api/commit/c5d57859d6f17322210c850b507840114a8dc9f6.

Updated

2 years ago
Priority: -- → P2
(Assignee)

Comment 1

2 years ago
Created attachment 8744838 [details]
MozReview Request: Bug 1265397 - Add a `length` attribute to OfflineAudioContext. r?smaug

Review commit: https://reviewboard.mozilla.org/r/48703/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48703/
Attachment #8744838 - Flags: review?(bugs)
Comment on attachment 8744838 [details]
MozReview Request: Bug 1265397 - Add a `length` attribute to OfflineAudioContext. r?smaug

https://reviewboard.mozilla.org/r/48703/#review45485

::: dom/media/webaudio/AudioContext.cpp:1050
(Diff revision 1)
>  
>    return promise.forget();
>  }
>  
> +unsigned long
> +AudioContext::Length() {

Nit, { goes to its own line.

::: dom/media/webaudio/AudioDestinationNode.h:89
(Diff revision 1)
>    size_t SizeOfIncludingThis(MallocSizeOf aMallocSizeOf) const override;
>  
>    void InputMuted(bool aInputMuted);
>    void ResolvePromise(AudioBuffer* aRenderedBuffer);
>  
> +  unsigned long Length() {

ditto
Attachment #8744838 - Flags: review?(bugs) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → padenot

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/baef9b5b939d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.